Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Hui Zhu <teawater@gmail.com>,
	gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [obv] Fix unused-but-set-variable error   [Re: [OB] Fix linux-low.c build error]
Date: Mon, 19 Dec 2011 10:23:00 -0000	[thread overview]
Message-ID: <20111219101316.GA5027@host2.jankratochvil.net> (raw)
In-Reply-To: <4EEED8FB.4040103@codesourcery.com>

On Mon, 19 Dec 2011 07:26:03 +0100, Yao Qi wrote:
> This reminds me that I committed a similar patch some days ago.  Here is a
> patch to revert.
[...]
> -	  /* Fix compiler's warning: ignoring return value of 'write'.  */
> -	  ret = write (fd, buf, 1);
> +	  if (write (fd, buf, 1) < 0)
> +	    /* Errors ignored.  */;
>  	  close (fd);
>  	}
>      }

I would add a comment that the variable "ret" is already used elsewhere incl.
reading it in that function.  This is the reason it did not trigger the
unused-but-set-variable error.

Still sure I agree such patch is useful (+Joel suggests more comments for it),
this is unwised code dependency.  .


Thanks,
Jan


      parent reply	other threads:[~2011-12-19 10:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 16:05 [OB] Fix linux-low.c build error Hui Zhu
2011-12-18 20:58 ` Jan Kratochvil
2011-12-18 22:55   ` [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error] Jan Kratochvil
2011-12-19  3:22     ` Hui Zhu
2011-12-19  3:34     ` Joel Brobecker
2011-12-19  6:50     ` Yao Qi
2011-12-19  6:53       ` Joel Brobecker
2011-12-19  8:13         ` Yao Qi
2011-12-19  9:32           ` Joel Brobecker
2011-12-19 10:23       ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219101316.GA5027@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox