From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32192 invoked by alias); 19 Dec 2011 03:22:13 -0000 Received: (qmail 32184 invoked by uid 22791); 19 Dec 2011 03:22:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Dec 2011 03:22:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6255F2BB2C8; Sun, 18 Dec 2011 22:21:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jkNanCZ7L8UU; Sun, 18 Dec 2011 22:21:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D946C2BB2BB; Sun, 18 Dec 2011 22:21:58 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 32F67145615; Sun, 18 Dec 2011 19:21:51 -0800 (PST) Date: Mon, 19 Dec 2011 03:34:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Hui Zhu , gdb-patches ml Subject: Re: [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error] Message-ID: <20111219032151.GL21915@adacore.com> References: <20111218192239.GA25401@host2.jankratochvil.net> <20111218205826.GA15385@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111218205826.GA15385@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00615.txt.bz2 In this case, I think that the warning was helpful regardless of the version of GCC that emitted it. However, I did think that Hui's solution was only sweeping the problem under the carpet and that did make me uncomfortable. > Checked in this alternative fix to not break the next nightly builds. I much prefer your solution which makes it obvious that we decided to ignore write errors. -- Joel