Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints
Date: Wed, 07 Dec 2011 10:07:00 -0000	[thread overview]
Message-ID: <20111207100101.GC21915@adacore.com> (raw)
In-Reply-To: <201112061718.50031.pedro@codesourcery.com>

> (gdb) catch exception
> Cannot insert catchpoints in this configuration.

We're going to have to talk to the guys who decided to build the Ada
runtime without debugging info. The normal way to build the runtime
is no debug info *except* for a few files. This is really doing a
disservice to the users!

Grumble, grumble, grumble. Sorry.

> but they don't match this specific error message.  I can't seem to find the
> "Cannot break on" string anywhere, is it escaping me?

It's actuall there, see ada-lang.c:ada_exception_sal. But upon more
careful inspection, I think it might have become dead code:
The error is only raised if we failed to look that symbol up, but
the call to ada_exception_support_info_sniffer to have already errored
out if that was the case. So I think we can replace that by an assertion
and simplify the testcase.

That's going to be on me, but I won't have much time this week.

In the meantime...

> (BTW, the "cannot insert catchpoints" error may be a bit confusing,
> considering there are other non-Ada catchpoints that will work just
> fine.)

I'll try to think of a better error message - it's not my forte...

> gdb/testsuite/
> 2011-12-06  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* gdb.ada/catch_ex.exp: Skip as unsupported if "catch exception"
> 	throws "Cannot insert catchpoints in this configuration".
> 	* gdb.ada/mi_catch_ex.exp: Likewise.

... I think that this is a good stop-gap measure. It helps you, so
it's OK to go in. I'll cleanup afterwards anyways.  Thanks for doing
that.

-- 
Joel


  reply	other threads:[~2011-12-07 10:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 17:33 Pedro Alves
2011-12-07 10:07 ` Joel Brobecker [this message]
2011-12-07 15:29   ` Pedro Alves
2011-12-07 16:10     ` Pedro Alves
2011-12-07 22:01   ` Tom Tromey
2011-12-07 23:18     ` Joel Brobecker
2011-12-09  3:50       ` Tom Tromey
2011-12-09 17:20       ` Pedro Alves
2011-12-09 18:00         ` Tom Tromey
2011-12-09 18:13           ` Pedro Alves
2011-12-09 18:40             ` Tom Tromey
2011-12-10 22:53               ` Pedro Alves
2011-12-11 20:33                 ` Joel Brobecker
2011-12-20 14:53                 ` Tom Tromey
2012-01-10 20:26                   ` Pedro Alves
2011-12-11 17:42   ` [commit] Ada exception catchpoint support cleanup Joel Brobecker
2011-12-11 17:44   ` [commit] Warn if missing debug info for Ada exception catchpoints Joel Brobecker
2011-12-11 18:04   ` [commit/Ada] improve message when cannot insert Ada exception catchpoint Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111207100101.GC21915@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox