From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13752 invoked by alias); 7 Dec 2011 10:01:18 -0000 Received: (qmail 13734 invoked by uid 22791); 7 Dec 2011 10:01:17 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Dec 2011 10:01:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6C6B92BAED2; Wed, 7 Dec 2011 05:01:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PLytq9shBliE; Wed, 7 Dec 2011 05:01:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3F3822BAED1; Wed, 7 Dec 2011 05:01:03 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6918C145615; Wed, 7 Dec 2011 02:01:01 -0800 (PST) Date: Wed, 07 Dec 2011 10:07:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints Message-ID: <20111207100101.GC21915@adacore.com> References: <201112061718.50031.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201112061718.50031.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00225.txt.bz2 > (gdb) catch exception > Cannot insert catchpoints in this configuration. We're going to have to talk to the guys who decided to build the Ada runtime without debugging info. The normal way to build the runtime is no debug info *except* for a few files. This is really doing a disservice to the users! Grumble, grumble, grumble. Sorry. > but they don't match this specific error message. I can't seem to find the > "Cannot break on" string anywhere, is it escaping me? It's actuall there, see ada-lang.c:ada_exception_sal. But upon more careful inspection, I think it might have become dead code: The error is only raised if we failed to look that symbol up, but the call to ada_exception_support_info_sniffer to have already errored out if that was the case. So I think we can replace that by an assertion and simplify the testcase. That's going to be on me, but I won't have much time this week. In the meantime... > (BTW, the "cannot insert catchpoints" error may be a bit confusing, > considering there are other non-Ada catchpoints that will work just > fine.) I'll try to think of a better error message - it's not my forte... > gdb/testsuite/ > 2011-12-06 Pedro Alves > > * gdb.ada/catch_ex.exp: Skip as unsupported if "catch exception" > throws "Cannot insert catchpoints in this configuration". > * gdb.ada/mi_catch_ex.exp: Likewise. ... I think that this is a good stop-gap measure. It helps you, so it's OK to go in. I'll cleanup afterwards anyways. Thanks for doing that. -- Joel