From: Joel Brobecker <brobecker@adacore.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org,
mark.kettenis@xs4all.nl, tromey@redhat.com
Subject: Re: Notes on -Wshadow patches
Date: Sun, 27 Nov 2011 17:59:00 -0000 [thread overview]
Message-ID: <20111127175910.GD24943@adacore.com> (raw)
In-Reply-To: <877h2l7nth.fsf@gmail.com>
Andrey,
> I finally finished squashing and reordering patches so here are some
> notes, before I start sending them.
It's really great that you've done all this work of giving us a better
overview of where the various problems lie. It feel a little bad asking
you for more work, but on the othe hand, it would be nice if you said
for each future patch what other entity causes the collision you're
trying to fix. I presume you already know, and that'll make our job
reviewing your changes a little faster.
--
Joel
next prev parent reply other threads:[~2011-11-27 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 12:27 Andrey Smirnov
2011-11-27 13:07 ` Eli Zaretskii
2011-11-27 14:15 ` Mark Kettenis
2011-11-27 20:55 ` Andrey Smirnov
2011-11-27 21:24 ` Andrey Smirnov
2011-11-27 21:52 ` Joel Brobecker
2011-11-27 17:59 ` Joel Brobecker [this message]
2011-11-27 21:17 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111127175910.GD24943@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.smirnov@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox