Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com,
	mark.kettenis@xs4all.nl, tromey@redhat.com
Subject: Re: Notes on -Wshadow patches
Date: Sun, 27 Nov 2011 13:07:00 -0000	[thread overview]
Message-ID: <E1RUeSM-0003Dc-Jd@fencepost.gnu.org> (raw)
In-Reply-To: <877h2l7nth.fsf@gmail.com> (message from Andrey Smirnov on Sun,	27 Nov 2011 19:27:22 +0700)

> From: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: eliz@gnu.org,
>     brobecker@adacore.com,
>     mark.kettenis@xs4all.nl,
>     tromey@redhat.com
> Date: Sun, 27 Nov 2011 19:27:22 +0700
> 
>   If there's something I'm missing, and the inclusion of ChangeLog
>   contents in a diff is unavoidable, let me know, and I will make
>   appropriate changes.

Doesn't git support generation of ChangeLog entries from commit
messages?  I thought it did.  If it does, you should be able to
generate ChangeLog entries automatically.

> * Some statistics

Thanks for the footwork.

>   - At least 1 in 3 detected conflicts was a conflict of either type ALBW or
>     BWHD, both of which, I hope we can all agree, are either
>     unintentional mistake or a hack too clever for it's own good, which
>     makes the later editing of the code into "Operation" game.

I actually think that both ALBW and BWHD are perfectly valid C code,
and neither unintentional mistakes nor "too clever hacks".  The only
type of clashes that should be fixed are TYP2.


  reply	other threads:[~2011-11-27 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27 12:27 Andrey Smirnov
2011-11-27 13:07 ` Eli Zaretskii [this message]
2011-11-27 14:15   ` Mark Kettenis
2011-11-27 20:55     ` Andrey Smirnov
2011-11-27 21:24   ` Andrey Smirnov
2011-11-27 21:52     ` Joel Brobecker
2011-11-27 17:59 ` Joel Brobecker
2011-11-27 21:17   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1RUeSM-0003Dc-Jd@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox