From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16754 invoked by alias); 27 Nov 2011 17:59:35 -0000 Received: (qmail 16746 invoked by uid 22791); 27 Nov 2011 17:59:35 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Nov 2011 17:59:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9A97A2BB0BC; Sun, 27 Nov 2011 12:59:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 48uHP4L8w2Ej; Sun, 27 Nov 2011 12:59:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 534382BB0B1; Sun, 27 Nov 2011 12:59:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D14B6145615; Sun, 27 Nov 2011 12:59:10 -0500 (EST) Date: Sun, 27 Nov 2011 17:59:00 -0000 From: Joel Brobecker To: Andrey Smirnov Cc: gdb-patches@sourceware.org, eliz@gnu.org, mark.kettenis@xs4all.nl, tromey@redhat.com Subject: Re: Notes on -Wshadow patches Message-ID: <20111127175910.GD24943@adacore.com> References: <877h2l7nth.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877h2l7nth.fsf@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00737.txt.bz2 Andrey, > I finally finished squashing and reordering patches so here are some > notes, before I start sending them. It's really great that you've done all this work of giving us a better overview of where the various problems lie. It feel a little bad asking you for more work, but on the othe hand, it would be nice if you said for each future patch what other entity causes the collision you're trying to fix. I presume you already know, and that'll make our job reviewing your changes a little faster. -- Joel