From: David Miller <davem@davemloft.net>
To: mark.kettenis@xs4all.nl
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build failure due to compiler warning.
Date: Wed, 23 Nov 2011 21:43:00 -0000 [thread overview]
Message-ID: <20111123.164331.1539372966997784895.davem@davemloft.net> (raw)
In-Reply-To: <201111231441.pANEfXDW022746@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
Date: Wed, 23 Nov 2011 15:41:33 +0100 (CET)
>> Date: Wed, 16 Nov 2011 01:12:17 -0500 (EST)
>> From: David Miller <davem@davemloft.net>
>>
>> On Sparc/Linux, __suseconds_t is not a type compatible with 'long' so
>> these printf statements trigger a warning and thus a build failure.
>>
>> This mirrors the casting already being done for the same exact reason
>> in vprintf_unfiltered.
>>
>> Ok to commit?
>
> Not sure if you already committed this, but "long int" sounds a bit
> pedantic, so I'd prefer to see this with "long". But either way, this
> is ok.
I did commit this, and I did use "long" as is mentioned in both my
description above and the ChangeLog entry :-)
prev parent reply other threads:[~2011-11-23 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 6:12 David Miller
2011-11-16 14:58 ` Tom Tromey
2011-11-23 14:42 ` Mark Kettenis
2011-11-23 21:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123.164331.1539372966997784895.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox