Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix build failure due to compiler warning.
Date: Wed, 16 Nov 2011 06:12:00 -0000	[thread overview]
Message-ID: <20111116.011217.835882743635387092.davem@davemloft.net> (raw)


On Sparc/Linux, __suseconds_t is not a type compatible with 'long' so
these printf statements trigger a warning and thus a build failure.

This mirrors the casting already being done for the same exact reason
in vprintf_unfiltered.

Ok to commit?

2011-11-15  David S. Miller  <davem@davemloft.net>

	* utils.c (report_command_stats): Cast delta_wall_time 'tv_sec' and
	'tv_usec' to long for printf since these fields have a type which
	varies.

diff --git a/gdb/utils.c b/gdb/utils.c
index 82a0f45..a1cf8fc 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -707,7 +707,8 @@ report_command_stats (void *arg)
 			 ? _("Startup time: %ld.%06ld (cpu), %ld.%06ld (wall)\n")
 			 : _("Command execution time: %ld.%06ld (cpu), %ld.%06ld (wall)\n"),
 			 cmd_time / 1000000, cmd_time % 1000000,
-			 delta_wall_time.tv_sec, delta_wall_time.tv_usec);
+			 (long int) delta_wall_time.tv_sec,
+			 (long int) delta_wall_time.tv_usec);
     }
 
   if (display_space)


             reply	other threads:[~2011-11-16  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16  6:12 David Miller [this message]
2011-11-16 14:58 ` Tom Tromey
2011-11-23 14:42 ` Mark Kettenis
2011-11-23 21:43   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111116.011217.835882743635387092.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox