From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30994 invoked by alias); 23 Nov 2011 21:43:49 -0000 Received: (qmail 30984 invoked by uid 22791); 23 Nov 2011 21:43:48 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 21:43:33 +0000 Received: from localhost (cpe-66-65-61-233.nyc.res.rr.com [66.65.61.233]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id pANLhVYH025977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Nov 2011 13:43:32 -0800 Date: Wed, 23 Nov 2011 21:43:00 -0000 Message-Id: <20111123.164331.1539372966997784895.davem@davemloft.net> To: mark.kettenis@xs4all.nl Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix build failure due to compiler warning. From: David Miller In-Reply-To: <201111231441.pANEfXDW022746@glazunov.sibelius.xs4all.nl> References: <20111116.011217.835882743635387092.davem@davemloft.net> <201111231441.pANEfXDW022746@glazunov.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00660.txt.bz2 From: Mark Kettenis Date: Wed, 23 Nov 2011 15:41:33 +0100 (CET) >> Date: Wed, 16 Nov 2011 01:12:17 -0500 (EST) >> From: David Miller >> >> On Sparc/Linux, __suseconds_t is not a type compatible with 'long' so >> these printf statements trigger a warning and thus a build failure. >> >> This mirrors the casting already being done for the same exact reason >> in vprintf_unfiltered. >> >> Ok to commit? > > Not sure if you already committed this, but "long int" sounds a bit > pedantic, so I'd prefer to see this with "long". But either way, this > is ok. I did commit this, and I did use "long" as is mentioned in both my description above and the ChangeLog entry :-)