From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, tromey@redhat.com
Subject: Re: Checked in: [RFA] read_frame_register_value and big endian arches
Date: Fri, 18 Nov 2011 02:01:00 -0000 [thread overview]
Message-ID: <20111118020121.GA2703@adacore.com> (raw)
In-Reply-To: <201111161822.pAGIMpx5015021@d06av02.portsmouth.uk.ibm.com>
> It seems this completely broke reading of register variables on SPU. These
> are in the high-order element of the (always vector) registers, even though
> we have a big-endian architecture.
Ooops, sorry about that.
> It seems the underlying problem is that your new
> read_frame_register_value routine completely ignores the value_offset
> of the lval_register value.
Yeah, I'm not very with that part of struct values.
> note that for big-endian architectures, value_offset is already
> correct, so if you'd respect it, you wouldn't need any special-purpose
> big-endian code.
>
> Also, if you'd respect value_offset, the SPU special cases would work.
I will try to fix ASAP. I am sorry if that caused some fustration
when trying to do your testing. I didn't want to do the work in
the first place but I, too, got my testing broken by someone else's
change!
--
Joel
next prev parent reply other threads:[~2011-11-18 2:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 21:03 [RFA/RFC] Restore old handling of multi-register variables Joel Brobecker
2011-10-06 17:55 ` Pedro Alves
2011-10-06 20:11 ` Joel Brobecker
2011-10-06 21:00 ` Pedro Alves
2011-10-07 16:38 ` Joel Brobecker
2011-10-07 16:52 ` Pedro Alves
2011-10-22 14:48 ` Joel Brobecker
2011-10-25 19:34 ` Pedro Alves
2011-10-25 20:37 ` Joel Brobecker
2011-10-25 21:09 ` Pedro Alves
2011-10-26 21:44 ` Joel Brobecker
2011-10-26 22:11 ` Joel Brobecker
2011-10-27 15:57 ` Tom Tromey
2011-10-27 17:51 ` Joel Brobecker
2011-10-27 2:56 ` Joel Brobecker
2011-10-27 11:10 ` Pedro Alves
2011-10-27 17:56 ` Joel Brobecker
2011-10-31 3:17 ` [RFA] read_frame_register_value and big endian arches Joel Brobecker
2011-11-07 19:42 ` Pedro Alves
2011-11-07 21:24 ` Joel Brobecker
2011-11-10 17:15 ` Checked in: " Joel Brobecker
2011-11-16 18:23 ` Ulrich Weigand
2011-11-18 2:01 ` Joel Brobecker [this message]
2011-11-18 17:40 ` Ulrich Weigand
2011-11-18 19:41 ` Joel Brobecker
2011-11-18 20:06 ` [commit] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118020121.GA2703@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox