From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: RFC: don't set the pspace on ordinary breakpoints
Date: Thu, 10 Nov 2011 17:49:00 -0000 [thread overview]
Message-ID: <201111101748.51057.pedro@codesourcery.com> (raw)
In-Reply-To: <m3d3czdind.fsf@fleche.redhat.com>
On Thursday 10 November 2011 16:52:38, Tom Tromey wrote:
> @@ -11825,6 +11811,7 @@ addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found)
> if (e.error == NOT_FOUND_ERROR
> && (b->condition_not_parsed
> || (b->loc && b->loc->shlib_disabled)
> + || (b->loc && b->loc->pspace->executing_startup)
> || b->enable_state == bp_disabled))
> not_found_and_ok = 1;
Is this necessary in this patch? I though this was related to
the new errors thrown from the linespec changes.
Otherwise looks good to me.
--
Pedro Alves
next prev parent reply other threads:[~2011-11-10 17:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 15:32 Tom Tromey
2011-10-31 1:03 ` Jan Kratochvil
2011-10-31 12:07 ` Yao Qi
2011-11-02 18:55 ` Pedro Alves
2011-11-02 19:47 ` Tom Tromey
2011-11-02 20:21 ` Pedro Alves
2011-11-03 14:01 ` Tom Tromey
2011-11-03 16:02 ` Pedro Alves
2011-11-03 19:33 ` Ulrich Weigand
2011-11-08 19:32 ` Tom Tromey
2011-11-08 20:23 ` Tom Tromey
2011-11-09 18:24 ` Tom Tromey
2011-11-09 18:30 ` Pedro Alves
2011-11-09 18:41 ` Tom Tromey
2011-11-10 16:53 ` Tom Tromey
2011-11-10 17:49 ` Pedro Alves [this message]
2011-11-10 17:57 ` Ulrich Weigand
2011-11-10 19:27 ` Tom Tromey
2011-11-10 20:23 ` Tom Tromey
2011-11-11 12:56 ` Ulrich Weigand
2011-11-11 14:47 ` Tom Tromey
2011-11-14 21:12 ` Tom Tromey
2011-11-16 18:37 ` Ulrich Weigand
2011-11-16 21:24 ` Tom Tromey
2011-11-18 18:31 ` Ulrich Weigand
2012-01-02 18:18 ` [7.4 regression] Stand-alone Cell debugging broken (Re: RFC: don't set the pspace on ordinary breakpoints) Ulrich Weigand
2012-01-03 3:15 ` Joel Brobecker
2012-01-03 20:29 ` Tom Tromey
2012-01-04 12:36 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111101748.51057.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox