From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2739 invoked by alias); 10 Nov 2011 17:49:10 -0000 Received: (qmail 2730 invoked by uid 22791); 10 Nov 2011 17:49:09 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 17:48:56 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ROYkA-0001r5-C3 from pedro_alves@mentor.com ; Thu, 10 Nov 2011 09:48:54 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 10 Nov 2011 17:48:52 +0000 From: Pedro Alves To: Tom Tromey Subject: Re: RFC: don't set the pspace on ordinary breakpoints Date: Thu, 10 Nov 2011 17:49:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Ulrich Weigand References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111101748.51057.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00285.txt.bz2 On Thursday 10 November 2011 16:52:38, Tom Tromey wrote: > @@ -11825,6 +11811,7 @@ addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found) > if (e.error == NOT_FOUND_ERROR > && (b->condition_not_parsed > || (b->loc && b->loc->shlib_disabled) > + || (b->loc && b->loc->pspace->executing_startup) > || b->enable_state == bp_disabled)) > not_found_and_ok = 1; Is this necessary in this patch? I though this was related to the new errors thrown from the linespec changes. Otherwise looks good to me. -- Pedro Alves