From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak
Date: Thu, 10 Nov 2011 16:37:00 -0000 [thread overview]
Message-ID: <20111110163721.GB5390@adacore.com> (raw)
In-Reply-To: <20111109194621.GS14508@adacore.com>
> > This tickled a memory:
> >
> > http://sourceware.org/ml/gdb-patches/2008-10/msg00683.html
> >
> > I didn't touch iterate_over_mappings though, so the old patch is
> > complementary.
>
> Argh. The part that changes the checks against zero might be a little
> theoretical, and thus have no real effect, but the missing cleanups
> are not. We should commit the patch. On solaris, I still cannot run
> the testsuite (causing an awful machine crash), but I can run the AdaCore
> testsuite. That's better than nothing.
I tested the patch, and found no regression, so I checked it in.
> > I think your patch is good. I agree it is cleaner the way you wrote it.
>
> Thanks for taking a look! I will commit momentarily.
This one is in as well....
--
Joel
prev parent reply other threads:[~2011-11-10 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 18:47 Joel Brobecker
2011-11-09 19:06 ` Tom Tromey
2011-11-09 19:46 ` Joel Brobecker
2011-11-09 19:52 ` Tom Tromey
2011-11-09 19:58 ` Joel Brobecker
2011-11-09 20:00 ` Tom Tromey
2011-11-10 16:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110163721.GB5390@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox