From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5359 invoked by alias); 10 Nov 2011 16:37:41 -0000 Received: (qmail 5344 invoked by uid 22791); 10 Nov 2011 16:37:40 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 16:37:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 129E42BAD70; Thu, 10 Nov 2011 11:37:25 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id grwtozplMhEI; Thu, 10 Nov 2011 11:37:25 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DC4FB2BAD03; Thu, 10 Nov 2011 11:37:24 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EFBD4145615; Thu, 10 Nov 2011 11:37:21 -0500 (EST) Date: Thu, 10 Nov 2011 16:37:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak Message-ID: <20111110163721.GB5390@adacore.com> References: <1320864439-12456-1-git-send-email-brobecker@adacore.com> <20111109194621.GS14508@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111109194621.GS14508@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00277.txt.bz2 > > This tickled a memory: > > > > http://sourceware.org/ml/gdb-patches/2008-10/msg00683.html > > > > I didn't touch iterate_over_mappings though, so the old patch is > > complementary. > > Argh. The part that changes the checks against zero might be a little > theoretical, and thus have no real effect, but the missing cleanups > are not. We should commit the patch. On solaris, I still cannot run > the testsuite (causing an awful machine crash), but I can run the AdaCore > testsuite. That's better than nothing. I tested the patch, and found no regression, so I checked it in. > > I think your patch is good. I agree it is cleaner the way you wrote it. > > Thanks for taking a look! I will commit momentarily. This one is in as well.... -- Joel