From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak
Date: Wed, 09 Nov 2011 19:58:00 -0000 [thread overview]
Message-ID: <20111109195759.GT14508@adacore.com> (raw)
In-Reply-To: <m3hb2ddqgi.fsf@fleche.redhat.com>
> Joel> Argh. The part that changes the checks against zero might be a little
> Joel> theoretical, and thus have no real effect, but the missing cleanups
> Joel> are not. We should commit the patch. On solaris, I still cannot run
> Joel> the testsuite (causing an awful machine crash), but I can run the AdaCore
> Joel> testsuite. That's better than nothing.
>
> Did/could you try the patch? I wrote it just based on reading the
> code, I can't try it at all. I can resend it if you want.
Yep, that was my intention - I meant to make that clear, but I am
juggling 3 different things at the same time, and quality is clearly
suffering :-(. In any case, I'm taking responsibility for testing it,
rebasing if necessary, and then getting it in for you.
--
Joel
next prev parent reply other threads:[~2011-11-09 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 18:47 Joel Brobecker
2011-11-09 19:06 ` Tom Tromey
2011-11-09 19:46 ` Joel Brobecker
2011-11-09 19:52 ` Tom Tromey
2011-11-09 19:58 ` Joel Brobecker [this message]
2011-11-09 20:00 ` Tom Tromey
2011-11-10 16:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109195759.GT14508@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox