From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17028 invoked by alias); 9 Nov 2011 19:58:21 -0000 Received: (qmail 17020 invoked by uid 22791); 9 Nov 2011 19:58:21 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 19:58:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 977502BB195; Wed, 9 Nov 2011 14:58:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Gi0ltlbl9NKX; Wed, 9 Nov 2011 14:58:08 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6C0CB2BB161; Wed, 9 Nov 2011 14:58:08 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 512EE145615; Wed, 9 Nov 2011 14:57:59 -0500 (EST) Date: Wed, 09 Nov 2011 19:58:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak Message-ID: <20111109195759.GT14508@adacore.com> References: <1320864439-12456-1-git-send-email-brobecker@adacore.com> <20111109194621.GS14508@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00261.txt.bz2 > Joel> Argh. The part that changes the checks against zero might be a little > Joel> theoretical, and thus have no real effect, but the missing cleanups > Joel> are not. We should commit the patch. On solaris, I still cannot run > Joel> the testsuite (causing an awful machine crash), but I can run the AdaCore > Joel> testsuite. That's better than nothing. > > Did/could you try the patch? I wrote it just based on reading the > code, I can't try it at all. I can resend it if you want. Yep, that was my intention - I meant to make that clear, but I am juggling 3 different things at the same time, and quality is clearly suffering :-(. In any case, I'm taking responsibility for testing it, rebasing if necessary, and then getting it in for you. -- Joel