Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* New ARI warning Sat Oct 29 01:55:04 UTC 2011
@ 2011-10-29  7:27 GDB Administrator
  2011-10-30 22:59 ` Joel Brobecker
  0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2011-10-29  7:27 UTC (permalink / raw)
  To: gdb-patches

456a457
> gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/linux-nat.c:3424:	     other than the leader exec'd.  On an exec, the Linux


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Oct 29 01:55:04 UTC 2011
  2011-10-29  7:27 New ARI warning Sat Oct 29 01:55:04 UTC 2011 GDB Administrator
@ 2011-10-30 22:59 ` Joel Brobecker
  2011-10-31  0:11   ` Mark Kettenis
  2011-10-31 12:21   ` Pedro Alves
  0 siblings, 2 replies; 4+ messages in thread
From: Joel Brobecker @ 2011-10-30 22:59 UTC (permalink / raw)
  To: GDB Administrator; +Cc: gdb-patches

> > gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/linux-nat.c:3424:	     other than the leader exec'd.  On an exec, the Linux

I wonder if we want to consider the idea of getting rid of this rule
from the ARI... In this case, the comment correctly says "Linux kernel",
except that the "kernel" part is on the next line... It's not the first
time that this rule triggers unnecessarily, hence the suggestion.

-- 
Joel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Oct 29 01:55:04 UTC 2011
  2011-10-30 22:59 ` Joel Brobecker
@ 2011-10-31  0:11   ` Mark Kettenis
  2011-10-31 12:21   ` Pedro Alves
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2011-10-31  0:11 UTC (permalink / raw)
  To: brobecker; +Cc: gdbadmin, gdb-patches

> Date: Sun, 30 Oct 2011 15:52:35 -0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > > gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/linux-nat.c:3424:	     other than the leader exec'd.  On an exec, the Linux
> 
> I wonder if we want to consider the idea of getting rid of this rule
> from the ARI... In this case, the comment correctly says "Linux kernel",
> except that the "kernel" part is on the next line... It's not the first
> time that this rule triggers unnecessarily, hence the suggestion.

The rule is silly; I've never cared about the whole GNU/Linux politics
anyway,


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ARI warning Sat Oct 29 01:55:04 UTC 2011
  2011-10-30 22:59 ` Joel Brobecker
  2011-10-31  0:11   ` Mark Kettenis
@ 2011-10-31 12:21   ` Pedro Alves
  1 sibling, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2011-10-31 12:21 UTC (permalink / raw)
  To: gdb-patches; +Cc: Joel Brobecker, GDB Administrator

On Sunday 30 October 2011 19:52:35, Joel Brobecker wrote:
> > > gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
> > gdb/linux-nat.c:3424:	     other than the leader exec'd.  On an exec, the Linux
> 
> I wonder if we want to consider the idea of getting rid of this rule
> from the ARI... In this case, the comment correctly says "Linux kernel",
> except that the "kernel" part is on the next line... It's not the first
> time that this rule triggers unnecessarily, hence the suggestion.

+1000.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-10-31 12:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-29  7:27 New ARI warning Sat Oct 29 01:55:04 UTC 2011 GDB Administrator
2011-10-30 22:59 ` Joel Brobecker
2011-10-31  0:11   ` Mark Kettenis
2011-10-31 12:21   ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox