From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14547 invoked by alias); 31 Oct 2011 12:07:19 -0000 Received: (qmail 14535 invoked by uid 22791); 31 Oct 2011 12:07:17 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Oct 2011 12:07:02 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RKqdo-00041R-MJ from pedro_alves@mentor.com ; Mon, 31 Oct 2011 05:07:00 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 31 Oct 2011 12:06:58 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: New ARI warning Sat Oct 29 01:55:04 UTC 2011 Date: Mon, 31 Oct 2011 12:21:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.1; x86_64; ; ) Cc: Joel Brobecker , GDB Administrator References: <20111029015504.GA24159@sourceware.org> <20111030195235.GC19246@adacore.com> In-Reply-To: <20111030195235.GC19246@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110311206.55887.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00819.txt.bz2 On Sunday 30 October 2011 19:52:35, Joel Brobecker wrote: > > > gdb/linux-nat.c:3424: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version > > gdb/linux-nat.c:3424: other than the leader exec'd. On an exec, the Linux > > I wonder if we want to consider the idea of getting rid of this rule > from the ARI... In this case, the comment correctly says "Linux kernel", > except that the "kernel" part is on the next line... It's not the first > time that this rule triggers unnecessarily, hence the suggestion. +1000. -- Pedro Alves