From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h
Date: Tue, 18 Oct 2011 00:16:00 -0000 [thread overview]
Message-ID: <20111017211042.GC19246@adacore.com> (raw)
In-Reply-To: <m3mxcz9w11.fsf@fleche.redhat.com>
> >> #ifdef HAVE_STDBOOL_H
> >> # include <stdbool.h>
> >> #else
> >> # define bool int
> >> # define true 1
> >> # define false 0
> >> #endif
>
> Joel> I don't know what the others feel about this, I'm always wary of
> Joel> this, but maybe I'm too paranoid. I remember using these sorts of
> Joel> defines, and getting into portability issues, but that was a very
> Joel> long time ago, and I don't remember the details. Perhaps I didn't
> Joel> do something right, or it's now OBE.
>
> GCC has done this for years and years.
> I think it has been a net positive for code readability.
OK, then it's fine for me as well.
--
Joel
prev parent reply other threads:[~2011-10-17 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 19:50 Mike Frysinger
2011-09-29 2:02 ` Mike Frysinger
2011-10-10 2:42 ` Mike Frysinger
2011-10-17 16:57 ` Joel Brobecker
2011-10-17 17:08 ` Mike Frysinger
2011-10-17 17:28 ` Joel Brobecker
2011-10-17 20:27 ` Mike Frysinger
2011-10-17 20:54 ` Joel Brobecker
2011-10-17 20:58 ` Mike Frysinger
2011-10-17 21:11 ` Tom Tromey
2011-10-18 0:16 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017211042.GC19246@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=tromey@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox