From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18416 invoked by alias); 17 Oct 2011 21:11:03 -0000 Received: (qmail 18405 invoked by uid 22791); 17 Oct 2011 21:11:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 21:10:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D8EEB2BAFD4; Mon, 17 Oct 2011 17:10:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id t8-4uxZGxt77; Mon, 17 Oct 2011 17:10:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A31BD2BAFB4; Mon, 17 Oct 2011 17:10:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AD992145615; Mon, 17 Oct 2011 17:10:42 -0400 (EDT) Date: Tue, 18 Oct 2011 00:16:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Mike Frysinger , gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h Message-ID: <20111017211042.GC19246@adacore.com> References: <1310410693-20883-1-git-send-email-vapier@gentoo.org> <201110171306.34450.vapier@gentoo.org> <20111017172603.GY19246@adacore.com> <201110171423.17537.vapier@gentoo.org> <20111017202717.GB19246@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00487.txt.bz2 > >> #ifdef HAVE_STDBOOL_H > >> # include > >> #else > >> # define bool int > >> # define true 1 > >> # define false 0 > >> #endif > > Joel> I don't know what the others feel about this, I'm always wary of > Joel> this, but maybe I'm too paranoid. I remember using these sorts of > Joel> defines, and getting into portability issues, but that was a very > Joel> long time ago, and I don't remember the details. Perhaps I didn't > Joel> do something right, or it's now OBE. > > GCC has done this for years and years. > I think it has been a net positive for code readability. OK, then it's fine for me as well. -- Joel