From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h
Date: Mon, 17 Oct 2011 16:57:00 -0000 [thread overview]
Message-ID: <20111017165024.GB17942@adacore.com> (raw)
In-Reply-To: <1310410693-20883-1-git-send-email-vapier@gentoo.org>
> The dv-cfi code uses the bool type but doesn't include the stdbool.h
> header. I didn't notice for Blackfin targets as the core Blackfin
> header will include stdbool.h, but most targets don't do this.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2011-07-11 Mike Frysinger <vapier@gentoo.org>
>
> * dv-cfi.c: Include stdbool.h.
I don't think that this is right. stdbool.h is C99, whereas GDB should
build with a C90 compiler.
What we should do is get rid of uses of true and false, and use the
typical zero/nonzero values instead. I think that the blackfin header
and code should be cleaned up accordingly as well.
--
Joel
next prev parent reply other threads:[~2011-10-17 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 19:50 Mike Frysinger
2011-09-29 2:02 ` Mike Frysinger
2011-10-10 2:42 ` Mike Frysinger
2011-10-17 16:57 ` Joel Brobecker [this message]
2011-10-17 17:08 ` Mike Frysinger
2011-10-17 17:28 ` Joel Brobecker
2011-10-17 20:27 ` Mike Frysinger
2011-10-17 20:54 ` Joel Brobecker
2011-10-17 20:58 ` Mike Frysinger
2011-10-17 21:11 ` Tom Tromey
2011-10-18 0:16 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017165024.GB17942@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox