From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28113 invoked by alias); 17 Oct 2011 16:50:48 -0000 Received: (qmail 28096 invoked by uid 22791); 17 Oct 2011 16:50:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 16:50:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A7F6E2BADFF; Mon, 17 Oct 2011 12:50:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id c3gAjf39eihY; Mon, 17 Oct 2011 12:50:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7B6EF2BADFD; Mon, 17 Oct 2011 12:50:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E7A3A145615; Mon, 17 Oct 2011 12:50:24 -0400 (EDT) Date: Mon, 17 Oct 2011 16:57:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h Message-ID: <20111017165024.GB17942@adacore.com> References: <1310410693-20883-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1310410693-20883-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00473.txt.bz2 > The dv-cfi code uses the bool type but doesn't include the stdbool.h > header. I didn't notice for Blackfin targets as the core Blackfin > header will include stdbool.h, but most targets don't do this. > > Signed-off-by: Mike Frysinger > > 2011-07-11 Mike Frysinger > > * dv-cfi.c: Include stdbool.h. I don't think that this is right. stdbool.h is C99, whereas GDB should build with a C90 compiler. What we should do is get rid of uses of true and false, and use the typical zero/nonzero values instead. I think that the blackfin header and code should be cleaned up accordingly as well. -- Joel