Re: New ARI warning Thu Oct 13 01:55:36 UTC 2011

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Thu, 13 Oct 2011 03:55:36 +0200, GDB Administrator wrote:
> 216a217
> > gdb/dwarf2-frame-tailcall.c:283: obsolete: get_frame_base: Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address.
> gdb/dwarf2-frame-tailcall.c:283:	addr = get_frame_base (this_frame) - cache->entry_cfa_sp_offset;

This comes from my:
	[patch 04/12] entryval#3: Virtual tail call frames
	http://sourceware.org/ml/gdb-patches/2011-09/msg00556.html

where the code is specific to gdbarch_sp_regnum, so I think it should operate
with this_frame->stack_addr, which is exactly what get_frame_base does.

I understand such code ($sp simulation with shift for return address in tail
call frames) could have been rather gdbarch-specific but I am not aware of any
gdbarch where it should be done differently.  If such gdbarch exists and there
is interest in fixing this very minor feature of the entryval patchset this
can be moved to gdbarch-specific code where maybe get_frame_base may not be
appropriate.  I have no idea without being aware of any such gdbarch.


Regards,
Jan