From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20472 invoked by alias); 13 Oct 2011 13:54:33 -0000 Received: (qmail 20460 invoked by uid 22791); 13 Oct 2011 13:54:32 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 13:54:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9DDsGti016532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Oct 2011 09:54:16 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9DDsEHM012879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Oct 2011 09:54:16 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9DDsDdB002873; Thu, 13 Oct 2011 15:54:13 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9DDsCJp002872; Thu, 13 Oct 2011 15:54:12 +0200 Date: Thu, 13 Oct 2011 13:54:00 -0000 From: Jan Kratochvil To: GDB Administrator Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Thu Oct 13 01:55:36 UTC 2011 Message-ID: <20111013135412.GA2276@host1.jankratochvil.net> References: <20111013015536.GA23787@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111013015536.GA23787@sourceware.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00392.txt.bz2 On Thu, 13 Oct 2011 03:55:36 +0200, GDB Administrator wrote: > 216a217 > > gdb/dwarf2-frame-tailcall.c:283: obsolete: get_frame_base: Replace get_frame_base with get_frame_id, get_frame_base_address, get_frame_locals_address, or get_frame_args_address. > gdb/dwarf2-frame-tailcall.c:283: addr = get_frame_base (this_frame) - cache->entry_cfa_sp_offset; This comes from my: [patch 04/12] entryval#3: Virtual tail call frames http://sourceware.org/ml/gdb-patches/2011-09/msg00556.html where the code is specific to gdbarch_sp_regnum, so I think it should operate with this_frame->stack_addr, which is exactly what get_frame_base does. I understand such code ($sp simulation with shift for return address in tail call frames) could have been rather gdbarch-specific but I am not aware of any gdbarch where it should be done differently. If such gdbarch exists and there is interest in fixing this very minor feature of the entryval patchset this can be moved to gdbarch-specific code where maybe get_frame_base may not be appropriate. I have no idea without being aware of any such gdbarch. Regards, Jan