Re: [RFA 5/8] New port: TI C6x: gdb port

[Pedro Alves <pedro@codesourcery.com>]

On Tuesday 09 August 2011 16:16:00, Yao Qi wrote:
> On 08/09/2011 10:01 PM, Pedro Alves wrote:
> > On Tuesday 09 August 2011 03:52:13, Yao Qi wrote:
> >> Yes, we have target descriptions for tic6x-uclinux, but don't have for
> >> tic6x-elf so far.  So the target description is initialized in
> >> tic6x-linux-tdep.c:_initialize_tic6x_linux_tdep.
> >>
> >> I think the target description initialization should be moved to
> >> tic6x-tdep.c:_initialize_tic6x_tdep, so tic6x-uclinux and tic6x-elf
> >> share the target descriptions.  In my new patch, target description
> >> initialization is moved to tic6x-tdep.c:_initialize_tic6x_tdep, and
> >> suffix "-linux" in feature names and files is removed (target
> >> description is revised accordingly).
> > 
> > You can't do that given the descriptions specify GNU/Linux osabi.
> > There should be linux, and non-linux variants.
> > 
> 
> Can't we get rid of osabi from xml description, and use them both for
> linux and non-linux?  Similar to arm's target descriptions.

We can, but that's a bit a step backwards.  arm's descriptions don't
set the osabi because the support for the osabi field element was added
after the descriptions were.  Having the target tell gdb the osabi makes
a multi-target gdb (*) figure out the correct arch even if you don't
specify an executable (for attach).
I believe that with an xi:include, the linux xml file would be minimal.
It's not a super important use case, so I won't insist.  Do as you prefer.

(*) - otherwise gdb assumes the default osabi as set by gdb/configure.tgt)

-- 
Pedro Alves