From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1427 invoked by alias); 9 Aug 2011 15:42:10 -0000 Received: (qmail 1415 invoked by uid 22791); 9 Aug 2011 15:42:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 15:41:55 +0000 Received: (qmail 17440 invoked from network); 9 Aug 2011 15:41:54 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Aug 2011 15:41:54 -0000 From: Pedro Alves To: Yao Qi Subject: Re: [RFA 5/8] New port: TI C6x: gdb port Date: Tue, 09 Aug 2011 15:42:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-10-generic; KDE/4.7.0; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <4E2638A6.1070406@codesourcery.com> <201108091501.31358.pedro@codesourcery.com> <4E414F30.6050508@codesourcery.com> In-Reply-To: <4E414F30.6050508@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201108091641.52349.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00197.txt.bz2 On Tuesday 09 August 2011 16:16:00, Yao Qi wrote: > On 08/09/2011 10:01 PM, Pedro Alves wrote: > > On Tuesday 09 August 2011 03:52:13, Yao Qi wrote: > >> Yes, we have target descriptions for tic6x-uclinux, but don't have for > >> tic6x-elf so far. So the target description is initialized in > >> tic6x-linux-tdep.c:_initialize_tic6x_linux_tdep. > >> > >> I think the target description initialization should be moved to > >> tic6x-tdep.c:_initialize_tic6x_tdep, so tic6x-uclinux and tic6x-elf > >> share the target descriptions. In my new patch, target description > >> initialization is moved to tic6x-tdep.c:_initialize_tic6x_tdep, and > >> suffix "-linux" in feature names and files is removed (target > >> description is revised accordingly). > > > > You can't do that given the descriptions specify GNU/Linux osabi. > > There should be linux, and non-linux variants. > > > > Can't we get rid of osabi from xml description, and use them both for > linux and non-linux? Similar to arm's target descriptions. We can, but that's a bit a step backwards. arm's descriptions don't set the osabi because the support for the osabi field element was added after the descriptions were. Having the target tell gdb the osabi makes a multi-target gdb (*) figure out the correct arch even if you don't specify an executable (for attach). I believe that with an xi:include, the linux xml file would be minimal. It's not a super important use case, so I won't insist. Do as you prefer. (*) - otherwise gdb assumes the default osabi as set by gdb/configure.tgt) -- Pedro Alves