Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Eliminate tui_command_loop
Date: Fri, 05 Aug 2011 13:02:00 -0000	[thread overview]
Message-ID: <201108051402.06224.pedro@codesourcery.com> (raw)
In-Reply-To: <m38vr9ylqz.fsf@fleche.redhat.com>

On Thursday 04 August 2011 21:17:40, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

> Pedro> -    tui_command_loop,
> 
> I think this was the last user of the command_loop_proc field.

Indeed.  Though,

/* Run the current command interpreter's main loop.  */
void
current_interp_command_loop (void)
{
  /* Somewhat messy.  For the moment prop up all the old ways of
     selecting the command loop.  `deprecated_command_loop_hook'
     should be deprecated.  */
  if (deprecated_command_loop_hook != NULL)
    deprecated_command_loop_hook ();
  else if (current_interpreter != NULL
	   && current_interpreter->procs->command_loop_proc != NULL)
    current_interpreter->procs->command_loop_proc (current_interpreter->data);
  else
    cli_command_loop ();
}

deprecated_command_loop_hook is used by insight.
Sounds like we could get rid of it, and make insight 
install a command_loop_proc callback in its interpreter.
(gdb/gdbtk/gdbtk-interp.c).

-- 
Pedro Alves


  reply	other threads:[~2011-08-05 13:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 20:11 Pedro Alves
2011-08-04 20:18 ` Tom Tromey
2011-08-05 13:02   ` Pedro Alves [this message]
2011-08-05 15:11     ` Tom Tromey
2011-08-04 20:39 ` Thiago Jung Bauermann
2011-08-05  3:49   ` Sergio Durigan Junior
2011-08-05 12:37   ` Pedro Alves
2011-09-10 12:51 ` Matt Rice
2011-09-10 16:52   ` Matt Rice
2011-09-10 18:47   ` Pedro Alves
2011-09-11  0:46     ` Matt Rice
2011-09-11 14:41       ` Matt Rice
2011-09-13  8:29         ` PR gdb/13175 (Re: Eliminate tui_command_loop) Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108051402.06224.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox