From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82847-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22313 invoked by alias); 5 Aug 2011 13:02:48 -0000
Received: (qmail 22293 invoked by uid 22791); 5 Aug 2011 13:02:46 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Aug 2011 13:02:12 +0000
Received: (qmail 29255 invoked from network); 5 Aug 2011 13:02:11 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 5 Aug 2011 13:02:11 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Subject: Re: Eliminate tui_command_loop
Date: Fri, 05 Aug 2011 13:02:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; )
Cc: gdb-patches@sourceware.org
References: <201108042110.45405.pedro@codesourcery.com> <m38vr9ylqz.fsf@fleche.redhat.com>
In-Reply-To: <m38vr9ylqz.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201108051402.06224.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00107.txt.bz2

On Thursday 04 August 2011 21:17:40, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

> Pedro> -    tui_command_loop,
> 
> I think this was the last user of the command_loop_proc field.

Indeed.  Though,

/* Run the current command interpreter's main loop.  */
void
current_interp_command_loop (void)
{
  /* Somewhat messy.  For the moment prop up all the old ways of
     selecting the command loop.  `deprecated_command_loop_hook'
     should be deprecated.  */
  if (deprecated_command_loop_hook != NULL)
    deprecated_command_loop_hook ();
  else if (current_interpreter != NULL
	   && current_interpreter->procs->command_loop_proc != NULL)
    current_interpreter->procs->command_loop_proc (current_interpreter->data);
  else
    cli_command_loop ();
}

deprecated_command_loop_hook is used by insight.
Sounds like we could get rid of it, and make insight 
install a command_loop_proc callback in its interpreter.
(gdb/gdbtk/gdbtk-interp.c).

-- 
Pedro Alves