From: Pedro Alves <pedro@codesourcery.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [0/6] breakpoints_ops for all kinds of breakpoints
Date: Mon, 25 Jul 2011 14:17:00 -0000 [thread overview]
Message-ID: <201107251236.46235.pedro@codesourcery.com> (raw)
In-Reply-To: <m3wrfajk50.fsf@redhat.com>
On Friday 22 July 2011 18:32:59, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:
>
> > I did yet a bit more work on:
> >
> > <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
> >
> > This converts all breakpoint kinds to the breakpoint_ops
> > mechanism.
> >
> > IMO, this is committable as is. WDYT?
>
> I think it is great. It clears up several (dozen) ambiguities with
> breakpoint operations. I don't think this will affect the Python
> breakpoint_ops work (other than some refactoring, but we'll come to that
> bridge when your work is checked in).
Yeah, I don't think your current patch would need more than a
some trivial updates, but then again, I did leave the print_one
method behind in this conversion, which was the method that
I raised having the issue that doesn't seem to fit for gdb's own
breakpoints currently, so we should clean that up before
considering exposing it as public API.
--
Pedro Alves
next prev parent reply other threads:[~2011-07-25 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 15:42 Pedro Alves
2011-07-22 17:33 ` Tom Tromey
2011-07-25 12:39 ` Pedro Alves
2011-07-25 16:20 ` Tom Tromey
2011-07-22 17:38 ` Phil Muldoon
2011-07-25 14:17 ` Pedro Alves [this message]
2011-07-25 14:40 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107251236.46235.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox