From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12144 invoked by alias); 25 Jul 2011 11:37:06 -0000 Received: (qmail 12070 invoked by uid 22791); 25 Jul 2011 11:37:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jul 2011 11:36:52 +0000 Received: (qmail 18418 invoked from network); 25 Jul 2011 11:36:51 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Jul 2011 11:36:51 -0000 From: Pedro Alves To: pmuldoon@redhat.com Subject: Re: [0/6] breakpoints_ops for all kinds of breakpoints Date: Mon, 25 Jul 2011 14:17:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201107221640.25105.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201107251236.46235.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00686.txt.bz2 On Friday 22 July 2011 18:32:59, Phil Muldoon wrote: > Pedro Alves writes: > > > I did yet a bit more work on: > > > > > > > > This converts all breakpoint kinds to the breakpoint_ops > > mechanism. > > > > IMO, this is committable as is. WDYT? > > I think it is great. It clears up several (dozen) ambiguities with > breakpoint operations. I don't think this will affect the Python > breakpoint_ops work (other than some refactoring, but we'll come to that > bridge when your work is checked in). Yeah, I don't think your current patch would need more than a some trivial updates, but then again, I did leave the print_one method behind in this conversion, which was the method that I raised having the issue that doesn't seem to fit for gdb's own breakpoints currently, so we should clean that up before considering exposing it as public API. -- Pedro Alves