From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [0/6] breakpoints_ops for all kinds of breakpoints
Date: Fri, 22 Jul 2011 17:33:00 -0000 [thread overview]
Message-ID: <m3aac6xmaq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201107221640.25105.pedro@codesourcery.com> (Pedro Alves's message of "Fri, 22 Jul 2011 16:40:25 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> I did yet a bit more work on:
Pedro> <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
Pedro> This converts all breakpoint kinds to the breakpoint_ops
Pedro> mechanism.
Pedro> IMO, this is committable as is. WDYT?
I read through them all. I think this is a great series. Please check
it in.
I'm not particularly fond of patch #4, but I understand why you did it,
and I agree that statically initialized vtables are a pain -- I am often
grepping for all instances and hoping I haven't missed one. (I wish we
could require designated initializers for these so I could more easily
search for field names...)
I think we could make most of the vtable pointers (but not objects due
to the initialization approach) const. I think that would help clarity
a bit. I'm happy to do this after these patches go in.
Tom
next prev parent reply other threads:[~2011-07-22 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 15:42 Pedro Alves
2011-07-22 17:33 ` Tom Tromey [this message]
2011-07-25 12:39 ` Pedro Alves
2011-07-25 16:20 ` Tom Tromey
2011-07-22 17:38 ` Phil Muldoon
2011-07-25 14:17 ` Pedro Alves
2011-07-25 14:40 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aac6xmaq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox