From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Cc: gdb-patches@sourceware.org,
"ext Tristan Gingold" <gingold@adacore.com>,
"André Pönitz" <andre.poenitz@nokia.com>
Subject: Re: [PATCH,gdb,Update3]: ensures that cie ptr of an fda is a cie
Date: Wed, 06 Jul 2011 18:16:00 -0000 [thread overview]
Message-ID: <20110706170323.GA28535@host1.jankratochvil.net> (raw)
In-Reply-To: <0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com>
On Wed, 06 Jul 2011 16:40:14 +0200, Fawzi Mohamed wrote:
> +/* Defines the type of eh_frames that are expected to be decoded: CIE, FDE
> + or any of them. */
^^^ Two spaces at the end of line.
> +
> +enum eh_frame_type
> +{
> + EH_CIE_TYPE_ID = 1 << 0,
> + EH_FDE_TYPE_ID = 1 << 1,
> + EH_CIE_OR_FDE_TYPE_ID = EH_CIE_TYPE_ID + EH_FDE_TYPE_ID
A nitpick but the intended operation is | , not + .
[...]
> @@ -2102,7 +2127,7 @@
> while (1)
> {
> ret = decode_frame_entry_1 (unit, start, eh_frame_p,
> - cie_table, fde_table);
> + cie_table, fde_table,entry_type);
^^ missing space (' ')
Thanks for the fix,
Jan
next prev parent reply other threads:[~2011-07-06 17:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 18:19 [PATCH,gdb]: " Fawzi Mohamed
2011-07-04 18:52 ` Joel Brobecker
2011-07-05 10:44 ` [PATCH,gdb, Update1]: " Fawzi Mohamed
2011-07-05 15:17 ` Joel Brobecker
2011-07-05 16:57 ` [PATCH,gdb, Update2]: " Fawzi Mohamed
2011-07-05 16:26 ` [PATCH,gdb]: " Tom Tromey
2011-07-06 14:45 ` [PATCH,gdb,Update3]: " Fawzi Mohamed
2011-07-06 18:16 ` Jan Kratochvil [this message]
2011-07-07 17:17 ` [PATCH,gdb,Update4]: " Fawzi Mohamed
2011-07-07 23:37 ` Tom Tromey
2011-07-11 17:19 ` [PATCH,gdb,Update6]: " Fawzi Mohamed
2011-07-11 21:52 ` Tom Tromey
2011-07-12 11:15 ` [PATCH,gdb,Update7]: " Fawzi Mohamed
2011-07-12 20:01 ` Tom Tromey
2011-07-15 15:34 ` FYI " Fawzi Mohamed
2011-07-07 18:48 ` [PATCH,gdb,Update5]: " Fawzi Mohamed
2011-07-07 19:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706170323.GA28535@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=andre.poenitz@nokia.com \
--cc=fawzi.mohamed@nokia.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox