From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82113-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19740 invoked by alias); 6 Jul 2011 17:57:33 -0000
Received: (qmail 19731 invoked by uid 22791); 6 Jul 2011 17:57:33 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 17:57:03 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p66Hug9I029672	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 6 Jul 2011 13:56:50 -0400
Received: from host1.jankratochvil.net (ovpn-113-91.phx2.redhat.com [10.3.113.91])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p66H3Q4q012839	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Wed, 6 Jul 2011 13:03:27 -0400
Received: from host1.jankratochvil.net (localhost [127.0.0.1])	by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p66H3Pdd001971;	Wed, 6 Jul 2011 19:03:25 +0200
Received: (from jkratoch@localhost)	by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p66H3OPd001970;	Wed, 6 Jul 2011 19:03:24 +0200
Date: Wed, 06 Jul 2011 18:16:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Cc: gdb-patches@sourceware.org, ext Tristan Gingold <gingold@adacore.com>,        =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= <andre.poenitz@nokia.com>
Subject: Re: [PATCH,gdb,Update3]: ensures that cie ptr of an fda is a cie
Message-ID: <20110706170323.GA28535@host1.jankratochvil.net>
References: <F1900C4A-1C06-4F4B-9048-16C9A3F03765@nokia.com> <m3aacsvgnd.fsf@fleche.redhat.com> <0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00208.txt.bz2

On Wed, 06 Jul 2011 16:40:14 +0200, Fawzi Mohamed wrote:
> +/* Defines the type of eh_frames that are expected to be decoded: CIE, FDE
> +   or any of them. */
                    ^^^ Two spaces at the end of line.

> +
> +enum eh_frame_type
> +{
> +  EH_CIE_TYPE_ID = 1 << 0,
> +  EH_FDE_TYPE_ID = 1 << 1,
> +  EH_CIE_OR_FDE_TYPE_ID = EH_CIE_TYPE_ID + EH_FDE_TYPE_ID

A nitpick but the intended operation is | , not + .


[...]
> @@ -2102,7 +2127,7 @@
>   while (1)
>     {
>       ret = decode_frame_entry_1 (unit, start, eh_frame_p,
> -                                  cie_table, fde_table);
> +				  cie_table, fde_table,entry_type);
   				                      ^^ missing space (' ')


Thanks for the fix,
Jan