Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Cc: "ext Jan Kratochvil" <jan.kratochvil@redhat.com>,
	gdb-patches@sourceware.org,
	"ext Tristan Gingold" <gingold@adacore.com>,
	"André Pönitz" <andre.poenitz@nokia.com>
Subject: Re: [PATCH,gdb,Update7]: ensures that cie ptr of an fda is a cie
Date: Tue, 12 Jul 2011 20:01:00 -0000	[thread overview]
Message-ID: <m34o2rgtx4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <B689E7A5-2FD7-4726-A9A9-C2151C777EAF@nokia.com> (Fawzi Mohamed's	message of "Tue, 12 Jul 2011 10:34:02 +0200")

>>>>> "Fawzi" == Fawzi Mohamed <fawzi.mohamed@nokia.com> writes:

Fawzi> 2011-07-07  Fawzi Mohamed  <fawzi.mohamed@nokia.com>
Fawzi> 	* dwarf2-frame.c (decode_frame_entry, decode_frame_entry_1): Ensure
Fawzi> 	that CIE pointer of an FDE really points to a CIE .

Still one nit.

Fawzi> +		  xfree(fde_table.entries);

Space before the open paren.

This is ok with this change.

If you do not have a sourceware account, let me know and I will get you
set up with one.

Please also send and commit a patch to add yourself to the
write-after-approval section of gdb/MAINTAINERS.

thanks,
Tom


  reply	other threads:[~2011-07-12 19:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 18:19 [PATCH,gdb]: " Fawzi Mohamed
2011-07-04 18:52 ` Joel Brobecker
2011-07-05 10:44   ` [PATCH,gdb, Update1]: " Fawzi Mohamed
2011-07-05 15:17     ` Joel Brobecker
2011-07-05 16:57       ` [PATCH,gdb, Update2]: " Fawzi Mohamed
2011-07-05 16:26 ` [PATCH,gdb]: " Tom Tromey
2011-07-06 14:45   ` [PATCH,gdb,Update3]: " Fawzi Mohamed
2011-07-06 18:16     ` Jan Kratochvil
2011-07-07 17:17       ` [PATCH,gdb,Update4]: " Fawzi Mohamed
2011-07-07 23:37         ` Tom Tromey
2011-07-11 17:19           ` [PATCH,gdb,Update6]: " Fawzi Mohamed
2011-07-11 21:52             ` Tom Tromey
2011-07-12 11:15               ` [PATCH,gdb,Update7]: " Fawzi Mohamed
2011-07-12 20:01                 ` Tom Tromey [this message]
2011-07-15 15:34                   ` FYI " Fawzi Mohamed
2011-07-07 18:48       ` [PATCH,gdb,Update5]: " Fawzi Mohamed
2011-07-07 19:38         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34o2rgtx4.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=andre.poenitz@nokia.com \
    --cc=fawzi.mohamed@nokia.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox