Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Thiago Jung Bauermann <bauerman@br.ibm.com>,
	gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Make ppc-linux-nat insert/remove breakpoint and watchpoint functions return -1.
Date: Wed, 06 Jul 2011 16:36:00 -0000	[thread overview]
Message-ID: <20110706163507.GA29308@adacore.com> (raw)
In-Reply-To: <20110706161150.GD2407@adacore.com>

> Looking at target.h:
> 
> | /* Insert a breakpoint at address BP_TGT->placed_address in the target
> |    machine.  Result is 0 for success, or an errno value.  */
> | 
> | extern int target_insert_breakpoint (struct gdbarch *gdbarch,
> |                                      struct bp_target_info *bp_tgt);
> 

Sorry, scrap that part - I was looking at the wrong method
(I should have been looking at the `hw' one....).

> That being said, it's ultra important IMO in that case that we add the
> documentation wherever missing, because these are used by all ports.

Makes that comment all the more relevant :).

So I guess we'll have to infer the expected behavior from the core
code that calls it. I am hoping that it's the same as with the non
hw versions! :)

-- 
Joel


  reply	other threads:[~2011-07-06 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 20:29 Thiago Jung Bauermann
2011-07-06 15:03 ` Tom Tromey
2011-07-06 16:12   ` Joel Brobecker
2011-07-06 16:36     ` Joel Brobecker [this message]
2011-07-06 19:38       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706163507.GA29308@adacore.com \
    --to=brobecker@adacore.com \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox