From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27517 invoked by alias); 6 Jul 2011 16:35:31 -0000 Received: (qmail 27284 invoked by uid 22791); 6 Jul 2011 16:35:29 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 16:35:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3C9A32BB456; Wed, 6 Jul 2011 12:35:10 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7ItR-EmacIwx; Wed, 6 Jul 2011 12:35:10 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 065D32BB455; Wed, 6 Jul 2011 12:35:09 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 65670145615; Wed, 6 Jul 2011 09:35:07 -0700 (PDT) Date: Wed, 06 Jul 2011 16:36:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Thiago Jung Bauermann , gdb-patches ml Subject: Re: [RFA] Make ppc-linux-nat insert/remove breakpoint and watchpoint functions return -1. Message-ID: <20110706163507.GA29308@adacore.com> References: <1309897267.3634.6.camel@hactar> <20110706161150.GD2407@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110706161150.GD2407@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00199.txt.bz2 > Looking at target.h: > > | /* Insert a breakpoint at address BP_TGT->placed_address in the target > | machine. Result is 0 for success, or an errno value. */ > | > | extern int target_insert_breakpoint (struct gdbarch *gdbarch, > | struct bp_target_info *bp_tgt); > Sorry, scrap that part - I was looking at the wrong method (I should have been looking at the `hw' one....). > That being said, it's ultra important IMO in that case that we add the > documentation wherever missing, because these are used by all ports. Makes that comment all the more relevant :). So I guess we'll have to infer the expected behavior from the core code that calls it. I am hoping that it's the same as with the non hw versions! :) -- Joel