From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Make ppc-linux-nat insert/remove breakpoint and watchpoint functions return -1.
Date: Wed, 06 Jul 2011 15:03:00 -0000 [thread overview]
Message-ID: <m3vcvfpic9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1309897267.3634.6.camel@hactar> (Thiago Jung Bauermann's message of "Tue, 05 Jul 2011 17:21:07 -0300")
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> target_{insert,remove}_{hw_breakpoint,watchpoint,mask_watchpoint} are
Thiago> supposed to return 0, 1 and -1 for success, unsupported and error,
Thiago> respectively.
I looked around for anything saying this, and couldn't find it.
Well -- I found it for target_insert_mask_watchpoint, but not other
cases.
And, at least in breakpoint.c:insert_bp_location, it seems to me that
the return value is expected to be an errno in one case -- search for
safe_strerror.
Maybe this code is in error? I really couldn't say; but it seems
inconsistent at best. Perhaps only parts of your patch could go in
as-is, what do you think?
Tom
next prev parent reply other threads:[~2011-07-06 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 20:29 Thiago Jung Bauermann
2011-07-06 15:03 ` Tom Tromey [this message]
2011-07-06 16:12 ` Joel Brobecker
2011-07-06 16:36 ` Joel Brobecker
2011-07-06 19:38 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vcvfpic9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox