Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [0/2] more OO, Ada exception catchpoints: intro
Date: Wed, 22 Jun 2011 13:20:00 -0000	[thread overview]
Message-ID: <201106221420.08780.pedro@codesourcery.com> (raw)

Continuing the catchpoints OO theme, Ada catchpoints are
mostly implemented in ada-lang.c, except for the corresponding
commands' themselves implementation, plus a couple of other
helpers.  In this mini-series, that builds on top of 
the series starting at
<http://sourceware.org/ml/gdb-patches/2011-06/msg00269.html>:

 - patch #1 moves the implementation and registration
   of the "catch exception/assert" commands to ada-lang.c.

 - patch #2 switches Ada catchpoints to the OO scheme
   similar to how other catchpoints have been converted in
   my previous series, and removes most of the knowledge about
   Ada catchpoints out of breakpoint.c (serving as proof/excuse
   for me to add a few more bits to breakpoint_ops and export
   a few functions from breakpoint.c :-) ).  The main benefit from
   the change, apart from making the code/design cleaner (IMO), is
   that this lifts the limitation that Ada catchpoints can't have
   user specified conditions.

(I think it might be nice even to move the whole bunch to
its own file (ada-lang.c is pretty big itself) afterwards,
though I'm not planning on doing that myself.)

No regressions on x86_64-linux (with an Ada runtime with debug info,
so that Ada catchpoints work).

Joel, WDYT?  Okay to apply?

(let me know if you'd like a combined patch make it
easier to test on your end)

-- 
Pedro Alves


             reply	other threads:[~2011-06-22 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 13:20 Pedro Alves [this message]
2011-06-22 16:35 ` Joel Brobecker
2011-06-22 17:56   ` Pedro Alves
2011-06-22 17:24 ` Tom Tromey
2011-06-22 18:14   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106221420.08780.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox