Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [0/2] more OO, Ada exception catchpoints: intro
Date: Wed, 22 Jun 2011 17:56:00 -0000	[thread overview]
Message-ID: <201106221855.52825.pedro@codesourcery.com> (raw)
In-Reply-To: <20110622163446.GB20676@adacore.com>

On Wednesday 22 June 2011 17:34:46, Joel Brobecker wrote:
> Hi Pedro,
> 
> > Joel, WDYT?  Okay to apply?
> 
> I looked at the changes, and I think that this is awesome work.

Thanks.

> I wish I had time right now to test it in our environment, but
> I am not sure I will.
> 
> I'm planning on doing a resync sometime early next week, so I'd
> just go ahead and commit - I will fix whatever fallout there is
> left.  

Okay, done.  (I just did a couple cosmetic changes to patch #2
before applying.)

> And I'll look at simplifying the exception condition
> handling a bit, since I think it will be cleaner to just get
> the value of the parameter, and then compare it with the address
> of the exception we want to stop on.

Might be a good idea.

> Thanks a lot, Pedro.

Welcome.

-- 
Pedro Alves


  reply	other threads:[~2011-06-22 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 13:20 Pedro Alves
2011-06-22 16:35 ` Joel Brobecker
2011-06-22 17:56   ` Pedro Alves [this message]
2011-06-22 17:24 ` Tom Tromey
2011-06-22 18:14   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106221855.52825.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox