From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13594 invoked by alias); 22 Jun 2011 13:20:27 -0000 Received: (qmail 13586 invoked by uid 22791); 22 Jun 2011 13:20:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jun 2011 13:20:12 +0000 Received: (qmail 32436 invoked from network); 22 Jun 2011 13:20:11 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Jun 2011 13:20:11 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [0/2] more OO, Ada exception catchpoints: intro Date: Wed, 22 Jun 2011 13:20:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Joel Brobecker MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201106221420.08780.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00296.txt.bz2 Continuing the catchpoints OO theme, Ada catchpoints are mostly implemented in ada-lang.c, except for the corresponding commands' themselves implementation, plus a couple of other helpers. In this mini-series, that builds on top of the series starting at : - patch #1 moves the implementation and registration of the "catch exception/assert" commands to ada-lang.c. - patch #2 switches Ada catchpoints to the OO scheme similar to how other catchpoints have been converted in my previous series, and removes most of the knowledge about Ada catchpoints out of breakpoint.c (serving as proof/excuse for me to add a few more bits to breakpoint_ops and export a few functions from breakpoint.c :-) ). The main benefit from the change, apart from making the code/design cleaner (IMO), is that this lifts the limitation that Ada catchpoints can't have user specified conditions. (I think it might be nice even to move the whole bunch to its own file (ada-lang.c is pretty big itself) afterwards, though I'm not planning on doing that myself.) No regressions on x86_64-linux (with an Ada runtime with debug info, so that Ada catchpoints work). Joel, WDYT? Okay to apply? (let me know if you'd like a combined patch make it easier to test on your end) -- Pedro Alves