From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: bauerman@br.ibm.com (Thiago Jung Bauermann)
Cc: gdb-patches@sourceware.org (gdb-patches ml)
Subject: Re: [needs doc review] Re: [RFA 3/3] Implement support for PowerPC BookE masked watchpoints
Date: Thu, 05 May 2011 11:07:00 -0000 [thread overview]
Message-ID: <201105051107.p45B7NNg007738@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <1304398554.2245.81.camel@hactar> from "Thiago Jung Bauermann" at May 03, 2011 01:55:54 AM
Thiago Jung Bauermann wrote:
> 2011-05-03 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
> Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> Implement support for PowerPC BookE masked watchpoints.
>
> gdb/
> *NEWS: Mention masked watchpoint support. Create "Changed commands"
> section.
Missing space.
> * breakpoint.h (struct breakpoint_ops) <works_in_software_mode>: New
> method. Initialize to NULL in all existing breakpoint_ops instances.
> (struct breakpoint) <hw_wp_mask>: New field.
> * breakpoint.c (is_masked_watchpoint): Add prototype.
> (update_watchpoint): Don't set b->val for masked watchpoints. Call
> breakpoint's breakpoint_ops.works_in_software_mode if available.
> (watchpoints_triggered): Handle the case of a hardware masked
> watchpoint trigger.
> (watchpoint_check): Likewise.
> (works_in_software_mode_watchpoint): New function.
> (insert_masked_watchpoint, remove_masked_watchpoint)
> (resources_needed_masked_watchpoint)
> (works_in_software_mode_masked_watchpoint, print_it_masked_watchpoint)
> (print_one_detail_masked_watchpoint, print_mention_masked_watchpoint)
> (print_recreate_masked_watchpoint, is_masked_watchpoint): New
> functions.
> (masked_watchpoint_breakpoint_ops): New structure.
> (watch_command_1): Check for the existence of the `mask' parameter.
> Set b->ops according to the type of hardware watchpoint being created.
> * ppc-linux-nat.c (ppc_linux_insert_mask_watchpoint)
> (ppc_linux_remove_mask_watchpoint)
> (ppc_linux_masked_watch_num_registers): New functions.
> (_initialize_ppc_linux_nat): Initialize to_insert_mask_watchpoint,
> to_remove_mask_watchpoint and to_masked_watch_num_registers.
> * target.c (update_current_target): Mention to_insert_mask_watchpoint,
> to_remove_mask_watchpoint, and to_masked_watch_num_registers.
> (target_insert_mask_watchpoint, target_remove_mask_watchpoint)
> (target_masked_watch_num_registers): New functions.
> * target.h (struct target_ops) <to_insert_mask_watchpoint>,
> <to_remove_mask_watchpoint>, <to_masked_watch_num_registers>: New
> methods.
> (target_insert_mask_watchpoint, target_remove_mask_watchpoint)
> (target_masked_watch_num_registers): Add prototypes.
>
> gdb/doc/
> * gdb.texinfo (Set Watchpoints): Document mask parameter.
> (PowerPC Embedded): Document masked watchpoints.
When Eli is happy with the doc parts, the rest is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2011-05-05 11:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 20:55 [RFA] " Thiago Jung Bauermann
2011-01-31 20:09 ` Thiago Jung Bauermann
2011-02-17 15:10 ` Ulrich Weigand
2011-04-18 21:22 ` [RFA 2/3] Demote to sw watchpoint only in update_watchpoint Thiago Jung Bauermann
2011-04-29 17:26 ` Ulrich Weigand
2011-05-03 4:56 ` Thiago Jung Bauermann
2011-05-03 6:05 ` Eli Zaretskii
2011-05-03 9:58 ` Pedro Alves
2011-05-03 16:57 ` Eli Zaretskii
2011-05-03 17:41 ` Pedro Alves
2011-05-03 18:03 ` Eli Zaretskii
2011-05-03 18:12 ` Pedro Alves
2011-05-03 20:30 ` Eli Zaretskii
2011-05-04 0:03 ` Thiago Jung Bauermann
2011-05-04 3:07 ` Eli Zaretskii
2011-05-04 22:21 ` Thiago Jung Bauermann
2011-05-05 3:09 ` Eli Zaretskii
2011-05-05 8:15 ` Pedro Alves
2011-05-05 10:28 ` Eli Zaretskii
2011-05-05 15:27 ` Pedro Alves
2011-05-05 16:27 ` Eli Zaretskii
2011-05-05 11:10 ` Ulrich Weigand
2011-05-05 15:21 ` Pedro Alves
2011-05-04 19:12 ` Thiago Jung Bauermann
2011-05-04 20:31 ` Eli Zaretskii
2011-05-04 22:22 ` Thiago Jung Bauermann
2011-05-05 11:04 ` Ulrich Weigand
2011-04-18 21:22 ` [RFA 1/3] Change watchpoint's enable state in do_enable_breakpoint Thiago Jung Bauermann
2011-04-29 17:21 ` Ulrich Weigand
2011-05-04 0:11 ` Thiago Jung Bauermann
2011-04-18 21:24 ` [RFA 3/3] Implement support for PowerPC BookE masked watchpoints Thiago Jung Bauermann
2011-04-29 17:46 ` Ulrich Weigand
2011-05-03 4:56 ` [needs doc review] " Thiago Jung Bauermann
2011-05-03 6:24 ` Eli Zaretskii
2011-05-05 21:57 ` Thiago Jung Bauermann
2011-05-06 10:28 ` Eli Zaretskii
2011-05-06 20:35 ` Thiago Jung Bauermann
2011-05-05 11:07 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105051107.p45B7NNg007738@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox