From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1225 invoked by alias); 5 May 2011 11:07:42 -0000 Received: (qmail 1216 invoked by uid 22791); 5 May 2011 11:07:41 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate3.uk.ibm.com (HELO mtagate3.uk.ibm.com) (194.196.100.163) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 11:07:27 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p45B7OMV023441 for ; Thu, 5 May 2011 11:07:24 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p45B8ab52011370 for ; Thu, 5 May 2011 12:08:36 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p45B7O3X007761 for ; Thu, 5 May 2011 05:07:24 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p45B7NNg007738; Thu, 5 May 2011 05:07:23 -0600 Message-Id: <201105051107.p45B7NNg007738@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 05 May 2011 13:07:22 +0200 Subject: Re: [needs doc review] Re: [RFA 3/3] Implement support for PowerPC BookE masked watchpoints To: bauerman@br.ibm.com (Thiago Jung Bauermann) Date: Thu, 05 May 2011 11:07:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (gdb-patches ml) In-Reply-To: <1304398554.2245.81.camel@hactar> from "Thiago Jung Bauermann" at May 03, 2011 01:55:54 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00124.txt.bz2 Thiago Jung Bauermann wrote: > 2011-05-03 Sergio Durigan Junior > Thiago Jung Bauermann > > Implement support for PowerPC BookE masked watchpoints. > > gdb/ > *NEWS: Mention masked watchpoint support. Create "Changed commands" > section. Missing space. > * breakpoint.h (struct breakpoint_ops) : New > method. Initialize to NULL in all existing breakpoint_ops instances. > (struct breakpoint) : New field. > * breakpoint.c (is_masked_watchpoint): Add prototype. > (update_watchpoint): Don't set b->val for masked watchpoints. Call > breakpoint's breakpoint_ops.works_in_software_mode if available. > (watchpoints_triggered): Handle the case of a hardware masked > watchpoint trigger. > (watchpoint_check): Likewise. > (works_in_software_mode_watchpoint): New function. > (insert_masked_watchpoint, remove_masked_watchpoint) > (resources_needed_masked_watchpoint) > (works_in_software_mode_masked_watchpoint, print_it_masked_watchpoint) > (print_one_detail_masked_watchpoint, print_mention_masked_watchpoint) > (print_recreate_masked_watchpoint, is_masked_watchpoint): New > functions. > (masked_watchpoint_breakpoint_ops): New structure. > (watch_command_1): Check for the existence of the `mask' parameter. > Set b->ops according to the type of hardware watchpoint being created. > * ppc-linux-nat.c (ppc_linux_insert_mask_watchpoint) > (ppc_linux_remove_mask_watchpoint) > (ppc_linux_masked_watch_num_registers): New functions. > (_initialize_ppc_linux_nat): Initialize to_insert_mask_watchpoint, > to_remove_mask_watchpoint and to_masked_watch_num_registers. > * target.c (update_current_target): Mention to_insert_mask_watchpoint, > to_remove_mask_watchpoint, and to_masked_watch_num_registers. > (target_insert_mask_watchpoint, target_remove_mask_watchpoint) > (target_masked_watch_num_registers): New functions. > * target.h (struct target_ops) , > , : New > methods. > (target_insert_mask_watchpoint, target_remove_mask_watchpoint) > (target_masked_watch_num_registers): Add prototypes. > > gdb/doc/ > * gdb.texinfo (Set Watchpoints): Document mask parameter. > (PowerPC Embedded): Document masked watchpoints. When Eli is happy with the doc parts, the rest is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com