From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jerome Guitton <guitton@adacore.com>
Subject: Re: [RFA] Support for x86 on-stack trampolines
Date: Wed, 04 May 2011 08:55:00 -0000 [thread overview]
Message-ID: <201105040955.27810.pedro@codesourcery.com> (raw)
In-Reply-To: <1304468424-2060-1-git-send-email-guitton@adacore.com>
One think I noted on a quick skim over the patch:
On Wednesday 04 May 2011 01:20:24, Jerome Guitton wrote:
> +static const struct frame_unwind i386_stack_tramp_frame_unwind =
> +{
> + NORMAL_FRAME,
> + default_frame_unwind_stop_reason,
default_frame_unwind_stop_reason is only used by
archs/targets that don't support tracepoints at the moment.
It shouldn't be used in any x86-specific unwinder.
If you reuse the this _frame_this_id method of the
epilogue unwinder, you should reuse the _unwind_stop_reason
method of the same unwinder, since you're effectively
also reusing i386_epilogue_frame_cache.
> + i386_epilogue_frame_this_id,
> + i386_frame_prev_register,
> + NULL,
> + i386_stack_tramp_frame_sniffer
> +};
> +\f
--
Pedro Alves
next prev parent reply other threads:[~2011-05-04 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 0:21 Jerome Guitton
2011-05-04 8:55 ` Pedro Alves [this message]
2011-05-04 14:52 ` Jerome Guitton
2011-05-04 10:20 ` Mark Kettenis
2011-05-04 15:17 ` Jerome Guitton
2011-05-04 15:31 ` Mark Kettenis
2011-05-05 15:10 ` Jerome Guitton
2011-05-05 15:18 ` Mark Kettenis
2011-05-05 16:03 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105040955.27810.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox