From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6177 invoked by alias); 4 May 2011 08:55:33 -0000 Received: (qmail 6168 invoked by uid 22791); 4 May 2011 08:55:31 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 08:55:17 +0000 Received: (qmail 6511 invoked from network); 4 May 2011 08:55:16 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 May 2011 08:55:16 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Support for x86 on-stack trampolines Date: Wed, 04 May 2011 08:55:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Jerome Guitton References: <1304468424-2060-1-git-send-email-guitton@adacore.com> In-Reply-To: <1304468424-2060-1-git-send-email-guitton@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105040955.27810.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00087.txt.bz2 One think I noted on a quick skim over the patch: On Wednesday 04 May 2011 01:20:24, Jerome Guitton wrote: > +static const struct frame_unwind i386_stack_tramp_frame_unwind = > +{ > + NORMAL_FRAME, > + default_frame_unwind_stop_reason, default_frame_unwind_stop_reason is only used by archs/targets that don't support tracepoints at the moment. It shouldn't be used in any x86-specific unwinder. If you reuse the this _frame_this_id method of the epilogue unwinder, you should reuse the _unwind_stop_reason method of the same unwinder, since you're effectively also reusing i386_epilogue_frame_cache. > + i386_epilogue_frame_this_id, > + i386_frame_prev_register, > + NULL, > + i386_stack_tramp_frame_sniffer > +}; > + -- Pedro Alves