* [patch] testcase: PR 8210 corefiles threads
@ 2011-01-30 23:14 Jan Kratochvil
2011-04-19 20:44 ` [patch] testcase: PR 8210 corefiles threads #2 Jan Kratochvil
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kratochvil @ 2011-01-30 23:14 UTC (permalink / raw)
To: gdb-patches
Hi,
PR 8210 did not provide a new testcase, here it is. I have limited the check
only to *-*-linux* as other targets seem to identify the thread differently
(untested outside of GNU/Linux).
I will check it in after a while, it seems safe to me.
Tested on x86_64-fedora14-linux-gnu.
Thanks,
Jan
gdb/testsuite/
2011-01-30 Jan Kratochvil <jan.kratochvil@redhat.com>
Test PR corefiles/8210.
* gdb.threads/gcore-thread.exp (pthread_self): New.
New variables main_self, thread1_self, thread2_self.
(main pthread_self found, thread1 pthread_self found)
(thread2 pthread_self found): New tests.
--- ./gdb/testsuite/gdb.threads/gcore-thread.exp 2010-06-02 21:58:21.000000000 +0200
+++ ./gdb/testsuite/gdb.threads/gcore-thread.exp 2011-01-30 20:02:53.000000000 +0100
@@ -53,6 +53,19 @@ set horiz "\[^\n\r\]*"
# regexp for newline
set nl "\[\r\n\]+"
+proc pthread_self {name} {
+ global gdb_prompt
+
+ set test "print pthread_t of $name"
+ gdb_test_multiple "p/x (*(pthread_t (*)(void)) pthread_self) ()" $test {
+ -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" {
+ pass $test
+ return $expect_out(1,string)
+ }
+ }
+ return ""
+}
+
set prev_timeout $timeout
set timeout 30
@@ -82,15 +95,19 @@ gdb_test_multiple "info threads" "thread
}
}
+set main_self [pthread_self main]
+
# Make sure thread 1 is running
delete_breakpoints
gdb_breakpoint "thread1"
gdb_test "continue" "Continuing.*Breakpoint.* thread1 .*" "thread 1 is running"
+set thread1_self [pthread_self thread1]
# Make sure thread 2 is running
delete_breakpoints
gdb_breakpoint "thread2"
gdb_test "continue" "Continuing.*Breakpoint.* thread2 .*" "thread 2 is running"
+set thread2_self [pthread_self thread2]
set escapedfilename [string_to_regexp ${objdir}/${subdir}/gcore.test]
# Drop corefile
@@ -159,4 +176,10 @@ gdb_test "info threads" ".* thread2 .*"
gdb_test "info threads" ".*${nl}\\* ${horiz} thread2 .*" \
"thread2 is current thread in corefile"
+if [istarget "*-*-linux*"] then {
+ gdb_test "info threads" "Thread $main_self .*" "main pthread_self found"
+ gdb_test "info threads" "Thread $thread1_self .*" "thread1 pthread_self found"
+ gdb_test "info threads" "Thread $thread2_self .*" "thread2 pthread_self found"
+}
+
set timeout $prev_timeout
^ permalink raw reply [flat|nested] 6+ messages in thread* [patch] testcase: PR 8210 corefiles threads #2 2011-01-30 23:14 [patch] testcase: PR 8210 corefiles threads Jan Kratochvil @ 2011-04-19 20:44 ` Jan Kratochvil 2011-04-20 18:50 ` Tom Tromey 2011-04-24 15:07 ` [patch] testcase: PR 8210 corefiles threads #3 Jan Kratochvil 0 siblings, 2 replies; 6+ messages in thread From: Jan Kratochvil @ 2011-04-19 20:44 UTC (permalink / raw) To: gdb-patches Hi, the testcase originally submitted did not work with FSF GDB as it was based on gcore which does not provide enough prstatus/prpsinfo info in the core files and which are fixed by Denys Vlasenko's off-trunk patch: http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master Therefore this testcase uses native kernel core dumping instead. No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu. And also on ppc64-m64, ppc64-m32, s390x, s390 and ia64 (some having a bfd/ dependency to be posted now). Thanks, Jan On Sun, 30 Jan 2011 20:11:28 +0100, Jan Kratochvil wrote: PR 8210 did not provide a new testcase, here it is. I have limited the check only to *-*-linux* as other targets seem to identify the thread differently (untested outside of GNU/Linux). I will check it in after a while, it seems safe to me. gdb/testsuite/ 2011-04-19 Jan Kratochvil <jan.kratochvil@redhat.com> * gdb.threads/corethreads.c: New file. * gdb.threads/corethreads.exp: New file. --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.c @@ -0,0 +1,47 @@ +/* Copyright 2011 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <pthread.h> +#include <stdlib.h> +#include <assert.h> + +pthread_t thread0; +pthread_t thread1; + +static void * +start (void *arg) +{ + assert (pthread_self () == thread1); + + abort (); +} + +int +main (void) +{ + int i; + + thread0 = pthread_self (); + + i = pthread_create (&thread1, NULL, start, NULL); + assert (i == 0); + + i = pthread_join (thread1, NULL); + assert (i == 0); + + return 0; +} --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.exp @@ -0,0 +1,57 @@ +# Copyright 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Are we on a target board? And non-Linux targets seem to identify the thread +# differently. +if {![isnative] || ![istarget "*-*-linux*"]} { + return +} + +set testfile "corethreads" +set srcfile ${testfile}.c +set executable ${testfile} +set binfile ${objdir}/${subdir}/${executable} +if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + untested ${testfile}.exp + return -1 +} + +set corefile [core_find $binfile] +if {$corefile == ""} { + return 0 +} + +clean_restart $executable + +gdb_test "core-file $corefile" "Core was generated by .*" "load core" +gdb_test "info files" "\r\nLocal core dump file:\r\n.*" "sanity check we see the core file" + +set test "print pthread_t of thread0" +gdb_test_multiple "p/x thread0" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread0 $expect_out(1,string) + } +} +set test "print pthread_t of thread1" +gdb_test_multiple "p/x thread1" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread1 $expect_out(1,string) + } +} + +gdb_test "info threads" "Thread $thread0 .*" "thread0 found" +gdb_test "info threads" "Thread $thread1 .*" "thread1 found" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] testcase: PR 8210 corefiles threads #2 2011-04-19 20:44 ` [patch] testcase: PR 8210 corefiles threads #2 Jan Kratochvil @ 2011-04-20 18:50 ` Tom Tromey 2011-04-20 18:57 ` Jan Kratochvil 2011-04-24 15:07 ` [patch] testcase: PR 8210 corefiles threads #3 Jan Kratochvil 1 sibling, 1 reply; 6+ messages in thread From: Tom Tromey @ 2011-04-20 18:50 UTC (permalink / raw) To: Jan Kratochvil; +Cc: gdb-patches >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes: Jan> the testcase originally submitted did not work with FSF GDB as it Jan> was based on gcore which does not provide enough prstatus/prpsinfo Jan> info in the core files and which are fixed by Denys Vlasenko's Jan> off-trunk patch: Jan> http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master Is there a particular reason this hasn't been pushed upstream? Tom ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] testcase: PR 8210 corefiles threads #2 2011-04-20 18:50 ` Tom Tromey @ 2011-04-20 18:57 ` Jan Kratochvil 0 siblings, 0 replies; 6+ messages in thread From: Jan Kratochvil @ 2011-04-20 18:57 UTC (permalink / raw) To: Tom Tromey; +Cc: gdb-patches On Wed, 20 Apr 2011 20:49:47 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes: > Jan> http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master > > Is there a particular reason this hasn't been pushed upstream? I do not find it ready, for example elf_backend_write_core_note should be also changed etc. Feel free to take it. So far pushing/committing patches more ready for upstreaming when I find the time. Also even if it would be pushed I find this new testcase to make more safe by relying on the more established kernel core files producer. It was only a bit but still tricky to find out this dependency for me before. Thanks, Jan ^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] testcase: PR 8210 corefiles threads #3 2011-04-19 20:44 ` [patch] testcase: PR 8210 corefiles threads #2 Jan Kratochvil 2011-04-20 18:50 ` Tom Tromey @ 2011-04-24 15:07 ` Jan Kratochvil 2011-05-06 16:04 ` [commit] " Jan Kratochvil 1 sibling, 1 reply; 6+ messages in thread From: Jan Kratochvil @ 2011-04-24 15:07 UTC (permalink / raw) To: gdb-patches Hi, the testcase originally submitted did not catch a failure in BFD resulting in the output: p/x thread0 $1 = 0xfff2210 p/x thread1 $2 = 0xf7fef4c0 info threads 3 Thread 0xfff2210 (LWP 1) warning: Couldn't find general-purpose registers in core file. 0x00000000 in ?? () 2 Thread 26859 0x0ff02698 in clone () from /lib/power6/libc.so.6 * 1 Thread 0xf7fef4c0 (LWP 26860) 0x0fe45e40 in raise () from /lib/power6/libc.so.6 (gdb) _ As both thread ids are present there in this case but apparently the output is not correct. (This output is from gdb-7.0.1-37.el5 on powerpc64-linux-gnu, the testcase needs to be different there a bit). The testcase now requires exactly two lines and only threads 1 and 2. Thanks, Jan On Tue, 19 Apr 2011 22:43:52 +0200, Jan Kratochvil wrote: the testcase originally submitted did not work with FSF GDB as it was based on gcore which does not provide enough prstatus/prpsinfo info in the core files and which are fixed by Denys Vlasenko's off-trunk patch: http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master Therefore this testcase uses native kernel core dumping instead. No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu. And also on ppc64-m64, ppc64-m32, s390x, s390 and ia64 (some having a bfd/ dependency to be posted now). On Sun, 30 Jan 2011 20:11:28 +0100, Jan Kratochvil wrote: PR 8210 did not provide a new testcase, here it is. I have limited the check only to *-*-linux* as other targets seem to identify the thread differently (untested outside of GNU/Linux). I will check it in after a while, it seems safe to me. gdb/testsuite/ 2011-04-24 Jan Kratochvil <jan.kratochvil@redhat.com> * gdb.threads/corethreads.c: New file. * gdb.threads/corethreads.exp: New file. --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.c @@ -0,0 +1,47 @@ +/* Copyright 2011 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#include <pthread.h> +#include <stdlib.h> +#include <assert.h> + +pthread_t thread0; +pthread_t thread1; + +static void * +start (void *arg) +{ + assert (pthread_self () == thread1); + + abort (); +} + +int +main (void) +{ + int i; + + thread0 = pthread_self (); + + i = pthread_create (&thread1, NULL, start, NULL); + assert (i == 0); + + i = pthread_join (thread1, NULL); + assert (i == 0); + + return 0; +} --- /dev/null +++ b/gdb/testsuite/gdb.threads/corethreads.exp @@ -0,0 +1,58 @@ +# Copyright 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Are we on a target board? And non-Linux targets seem to identify the thread +# differently. +if {![isnative] || ![istarget "*-*-linux*"]} { + return +} + +set testfile "corethreads" +set srcfile ${testfile}.c +set executable ${testfile} +set binfile ${objdir}/${subdir}/${executable} +if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + untested ${testfile}.exp + return -1 +} + +set corefile [core_find $binfile] +if {$corefile == ""} { + return 0 +} + +clean_restart $executable + +gdb_test "core-file $corefile" "Core was generated by .*" "load core" +gdb_test "info files" "\r\nLocal core dump file:\r\n.*" "sanity check we see the core file" + +set test "print pthread_t of thread0" +gdb_test_multiple "p/x thread0" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread0 $expect_out(1,string) + } +} +set test "print pthread_t of thread1" +gdb_test_multiple "p/x thread1" $test { + -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" { + pass $test + set thread1 $expect_out(1,string) + } +} + +gdb_test "info threads" "\r\n *\[12\] +Thread $thread0 .*" "thread0 found" +gdb_test "info threads" "\r\n *\\*? +\[12\] +Thread $thread1 .*" "thread1 found" +gdb_test "info threads" "\r\n\[ \t\]*Id\[ \t\]+Target\[ \t\]+Id\[ \t\]+Frame\[ \t\]*\r\n\[^\r\n\]+\r\n\[^\r\n\]+" "no other thread found" ^ permalink raw reply [flat|nested] 6+ messages in thread
* [commit] [patch] testcase: PR 8210 corefiles threads #3 2011-04-24 15:07 ` [patch] testcase: PR 8210 corefiles threads #3 Jan Kratochvil @ 2011-05-06 16:04 ` Jan Kratochvil 0 siblings, 0 replies; 6+ messages in thread From: Jan Kratochvil @ 2011-05-06 16:04 UTC (permalink / raw) To: gdb-patches On Sun, 24 Apr 2011 17:07:16 +0200, Jan Kratochvil wrote: > 2011-04-24 Jan Kratochvil <jan.kratochvil@redhat.com> > > * gdb.threads/corethreads.c: New file. > * gdb.threads/corethreads.exp: New file. Checked in: http://sourceware.org/ml/gdb-cvs/2011-05/msg00046.html Thanks, Jan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-06 16:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-01-30 23:14 [patch] testcase: PR 8210 corefiles threads Jan Kratochvil 2011-04-19 20:44 ` [patch] testcase: PR 8210 corefiles threads #2 Jan Kratochvil 2011-04-20 18:50 ` Tom Tromey 2011-04-20 18:57 ` Jan Kratochvil 2011-04-24 15:07 ` [patch] testcase: PR 8210 corefiles threads #3 Jan Kratochvil 2011-05-06 16:04 ` [commit] " Jan Kratochvil
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox