Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] testcase: PR 8210 corefiles threads #2
Date: Tue, 19 Apr 2011 20:44:00 -0000	[thread overview]
Message-ID: <20110419204352.GA10615@host1.jankratochvil.net> (raw)
In-Reply-To: <20110130191128.GA21123@host1.dyn.jankratochvil.net>

Hi,

the testcase originally submitted did not work with FSF GDB as it was based on
gcore which does not provide enough prstatus/prpsinfo info in the core files
and which are fixed by Denys Vlasenko's off-trunk patch:
	http://pkgs.fedoraproject.org/gitweb/?p=gdb.git;a=blob_plain;f=gdb-6.8-bz254229-gcore-prpsinfo.patch;hb=f15/master

Therefore this testcase uses native kernel core dumping instead.

No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu.
And also on ppc64-m64, ppc64-m32, s390x, s390 and ia64 (some having a bfd/
dependency to be posted now).


Thanks,
Jan


On Sun, 30 Jan 2011 20:11:28 +0100, Jan Kratochvil wrote:

PR 8210 did not provide a new testcase, here it is.  I have limited the check
only to *-*-linux* as other targets seem to identify the thread differently
(untested outside of GNU/Linux).

I will check it in after a while, it seems safe to me.


gdb/testsuite/
2011-04-19  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.threads/corethreads.c: New file.
	* gdb.threads/corethreads.exp: New file.

--- /dev/null
+++ b/gdb/testsuite/gdb.threads/corethreads.c
@@ -0,0 +1,47 @@
+/* Copyright 2011 Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <pthread.h>
+#include <stdlib.h>
+#include <assert.h>
+
+pthread_t thread0;
+pthread_t thread1;
+
+static void *
+start (void *arg)
+{
+  assert (pthread_self () == thread1);
+
+  abort ();
+}
+
+int
+main (void)
+{
+  int i;
+
+  thread0 = pthread_self ();
+
+  i = pthread_create (&thread1, NULL, start, NULL);
+  assert (i == 0);
+
+  i = pthread_join (thread1, NULL);
+  assert (i == 0);
+
+  return 0;
+}
--- /dev/null
+++ b/gdb/testsuite/gdb.threads/corethreads.exp
@@ -0,0 +1,57 @@
+# Copyright 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Are we on a target board?  And non-Linux targets seem to identify the thread
+# differently.
+if {![isnative] || ![istarget "*-*-linux*"]} {
+    return
+}
+
+set testfile "corethreads"
+set srcfile ${testfile}.c
+set executable ${testfile}
+set binfile ${objdir}/${subdir}/${executable}
+if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+     untested ${testfile}.exp
+     return -1
+}
+
+set corefile [core_find $binfile]
+if {$corefile == ""} {
+    return 0
+}
+
+clean_restart $executable
+
+gdb_test "core-file $corefile" "Core was generated by .*" "load core"
+gdb_test "info files" "\r\nLocal core dump file:\r\n.*" "sanity check we see the core file"
+
+set test "print pthread_t of thread0"
+gdb_test_multiple "p/x thread0" $test {
+    -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" {
+	pass $test
+	set thread0 $expect_out(1,string)
+    }
+}
+set test "print pthread_t of thread1"
+gdb_test_multiple "p/x thread1" $test {
+    -re " = (0x\[0-9a-f\]+)\r\n$gdb_prompt $" {
+	pass $test
+	set thread1 $expect_out(1,string)
+    }
+}
+
+gdb_test "info threads" "Thread $thread0 .*" "thread0 found"
+gdb_test "info threads" "Thread $thread1 .*" "thread1 found"


  reply	other threads:[~2011-04-19 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30 23:14 [patch] testcase: PR 8210 corefiles threads Jan Kratochvil
2011-04-19 20:44 ` Jan Kratochvil [this message]
2011-04-20 18:50   ` [patch] testcase: PR 8210 corefiles threads #2 Tom Tromey
2011-04-20 18:57     ` Jan Kratochvil
2011-04-24 15:07   ` [patch] testcase: PR 8210 corefiles threads #3 Jan Kratochvil
2011-05-06 16:04     ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110419204352.GA10615@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox