From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org, patches@linaro.org
Subject: Re: [rfc] Fix broken i386 signal unwinding (Re: graceful unwind termination when we'd need unavailable/uncollect memory or regis
Date: Thu, 31 Mar 2011 16:23:00 -0000 [thread overview]
Message-ID: <201103311619.p2VGJQpB012660@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201103311704.09593.pedro@codesourcery.com> from "Pedro Alves" at Mar 31, 2011 05:04:09 PM
Pedro Alves wrote:
> On Thursday 31 March 2011 14:57:51, Ulrich Weigand wrote:
> > It seems this change broke unwinding out of signal trampoline
> > frames on i386 for me. In this case, neither SAVED_SP nor
> > SAVED_SP_REG is set; instead, SP is supposed to be unwound
> > from memory (the trampoline stack frame) via SAVED_REGS.
> >
> > However, after your change, we now fall into the _got_constant
> > case and SP is always unwound as 0.
> >
> > The following patch fixes this for me, and gets about 50 test
> > cases back to PASS.
> >
> > Does this look right to you?
>
> Yes it does. Thanks much for tracking and fixing it.
OK, I've checked this in now.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2011-03-31 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 18:35 graceful unwind termination when we'd need unavailable/uncollect memory or registers to unwind further Pedro Alves
2011-02-28 15:42 ` Jan Kratochvil
2011-02-28 15:56 ` Pedro Alves
2011-02-28 18:50 ` Jan Kratochvil
2011-03-18 20:21 ` Pedro Alves
2011-03-21 10:09 ` Regression: " Jan Kratochvil
2011-03-21 20:46 ` Pedro Alves
2011-03-22 14:40 ` Pedro Alves
2011-03-22 15:36 ` Jan Kratochvil
2011-03-22 16:19 ` Pedro Alves
2011-03-21 17:46 ` [commit] Fix tramp-frame.c crash (Re: graceful unwind termination when we'd need unavailable/uncollect memory or registers to unwind further) Ulrich Weigand
2011-03-21 20:52 ` Pedro Alves
2011-03-31 14:43 ` [rfc] Fix broken i386 signal unwinding " Ulrich Weigand
2011-03-31 16:20 ` Pedro Alves
2011-03-31 16:23 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103311619.p2VGJQpB012660@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox