From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: [commit] Fix tramp-frame.c crash (Re: graceful unwind termination when we'd need unavailable/uncollect memory or registers to unwind further)
Date: Mon, 21 Mar 2011 17:46:00 -0000 [thread overview]
Message-ID: <201103211724.p2LHOjEk017286@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201102221834.42413.pedro@codesourcery.com> from "Pedro Alves" at Feb 22, 2011 06:34:42 PM
Pedro Alves wrote:
> (struct frame_unwind) <stop_reason>: New function pointer.
It seems you initialized this field in all statically allocated frame_unwind
structures, but not in those dynamically allocated and returned from the
tramp_frame_prepend_unwinder routine. This causes crashes on all platforms
that use the tramp-frame.c framework ...
Fixed by the following patch.
Tested on powerpc64-linux, committed to mainline.
Bye,
Ulrich
ChangeLog:
* tramp-frame.c (tramp_frame_prepend_unwinder): Set stop_reason
field in returned unwinder.
Index: gdb/tramp-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/tramp-frame.c,v
retrieving revision 1.21
diff -u -p -r1.21 tramp-frame.c
--- gdb/tramp-frame.c 1 Jan 2011 15:33:18 -0000 1.21
+++ gdb/tramp-frame.c 21 Mar 2011 17:14:17 -0000
@@ -163,6 +163,7 @@ tramp_frame_prepend_unwinder (struct gdb
unwinder->type = tramp_frame->frame_type;
unwinder->unwind_data = data;
unwinder->sniffer = tramp_frame_sniffer;
+ unwinder->stop_reason = default_frame_unwind_stop_reason;
unwinder->this_id = tramp_frame_this_id;
unwinder->prev_register = tramp_frame_prev_register;
frame_unwind_prepend_unwinder (gdbarch, unwinder);
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-03-21 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 18:35 graceful unwind termination when we'd need unavailable/uncollect memory or registers to unwind further Pedro Alves
2011-02-28 15:42 ` Jan Kratochvil
2011-02-28 15:56 ` Pedro Alves
2011-02-28 18:50 ` Jan Kratochvil
2011-03-18 20:21 ` Pedro Alves
2011-03-21 10:09 ` Regression: " Jan Kratochvil
2011-03-21 20:46 ` Pedro Alves
2011-03-22 14:40 ` Pedro Alves
2011-03-22 15:36 ` Jan Kratochvil
2011-03-22 16:19 ` Pedro Alves
2011-03-21 17:46 ` Ulrich Weigand [this message]
2011-03-21 20:52 ` [commit] Fix tramp-frame.c crash (Re: graceful unwind termination when we'd need unavailable/uncollect memory or registers to unwind further) Pedro Alves
2011-03-31 14:43 ` [rfc] Fix broken i386 signal unwinding " Ulrich Weigand
2011-03-31 16:20 ` Pedro Alves
2011-03-31 16:23 ` [rfc] Fix broken i386 signal unwinding (Re: graceful unwind termination when we'd need unavailable/uncollect memory or regis Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103211724.p2LHOjEk017286@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox