From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7998 invoked by alias); 31 Mar 2011 16:19:42 -0000 Received: (qmail 7990 invoked by uid 22791); 31 Mar 2011 16:19:41 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.uk.ibm.com (HELO mtagate1.uk.ibm.com) (194.196.100.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Mar 2011 16:19:35 +0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p2VGJSdO007676 for ; Thu, 31 Mar 2011 16:19:28 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2VGK4Zx1851604 for ; Thu, 31 Mar 2011 17:20:04 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2VGJSiJ012671 for ; Thu, 31 Mar 2011 10:19:28 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p2VGJQpB012660; Thu, 31 Mar 2011 10:19:26 -0600 Message-Id: <201103311619.p2VGJQpB012660@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 31 Mar 2011 18:19:26 +0200 Subject: Re: [rfc] Fix broken i386 signal unwinding (Re: graceful unwind termination when we'd need unavailable/uncollect memory or regis To: pedro@codesourcery.com (Pedro Alves) Date: Thu, 31 Mar 2011 16:23:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, patches@linaro.org In-Reply-To: <201103311704.09593.pedro@codesourcery.com> from "Pedro Alves" at Mar 31, 2011 05:04:09 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01221.txt.bz2 Pedro Alves wrote: > On Thursday 31 March 2011 14:57:51, Ulrich Weigand wrote: > > It seems this change broke unwinding out of signal trampoline > > frames on i386 for me. In this case, neither SAVED_SP nor > > SAVED_SP_REG is set; instead, SP is supposed to be unwound > > from memory (the trampoline stack frame) via SAVED_REGS. > > > > However, after your change, we now fall into the _got_constant > > case and SP is always unwound as 0. > > > > The following patch fixes this for me, and gets about 50 test > > cases back to PASS. > > > > Does this look right to you? > > Yes it does. Thanks much for tracking and fixing it. OK, I've checked this in now. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com